This repository has been archived by the owner on Jun 28, 2022. It is now read-only.
fix(build_gen): include httpbody import for java/go #3329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: cloudbuild
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #3329 +/- ##
=========================================
Coverage 87.13% 87.13%
Complexity 6120 6120
=========================================
Files 495 495
Lines 24174 24174
Branches 2638 2638
=========================================
Hits 21065 21065
Misses 2242 2242
Partials 867 867 Continue to review full report at Codecov.
|
alexander-fenster
approved these changes
Jan 20, 2021
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jan 20, 2021
🤖 I have created a release \*beep\* \*boop\* --- ### [2.10.3](https://www.github.com/googleapis/gapic-generator/compare/v2.10.2...v2.10.3) (2021-01-20) ### Bug Fixes * **build_gen:** include httpbody import for java/go ([#3329](https://www.github.com/googleapis/gapic-generator/issues/3329)) ([5b30a46](https://www.github.com/googleapis/gapic-generator/commit/5b30a46b0c63492262425e46fa81beca6fc2a1cb)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an API uses
google.api.HttpBodyin the proto, the Java and Go GAPIC targets fail to build for similar reasons. Java complains about having an implicit dependency, while Go complains about not having the dependency at all. So build_gen should inject the target as a direct dependency to the gapic_library targets.