Skip to content
This repository has been archived by the owner on Jun 28, 2022. It is now read-only.

fix: preserve the value of opt_args parameter #3319

Merged
merged 3 commits into from
Jan 8, 2021
Merged

fix: preserve the value of opt_args parameter #3319

merged 3 commits into from
Jan 8, 2021

Conversation

alexander-fenster
Copy link
Contributor

Needed for py_gapic_library rule.

Needed for `py_gapic_library` rule.
@alexander-fenster alexander-fenster requested a review from a team as a code owner December 18, 2020 06:18
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 18, 2020
Copy link
Contributor

@vam-google vam-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Dec 18, 2020

Codecov Report

Merging #3319 (74ffb07) into master (d284392) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3319   +/-   ##
=========================================
  Coverage     87.13%   87.13%           
  Complexity     6120     6120           
=========================================
  Files           495      495           
  Lines         24174    24174           
  Branches       2638     2638           
=========================================
  Hits          21065    21065           
  Misses         2242     2242           
  Partials        867      867           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d284392...74ffb07. Read the comment docs.

@busunkim96
Copy link
Contributor

Thanks @alexander-fenster!

@alexander-fenster alexander-fenster added the automerge Merge the pull request once unit tests and other checks pass. label Jan 8, 2021
@vam-google vam-google merged commit 60a2d2c into master Jan 8, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 8, 2021
@alexander-fenster alexander-fenster deleted the opt_args branch January 8, 2021 06:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants