Skip to content
This repository has been archived by the owner on Jun 28, 2022. It is now read-only.

[Node] Pub Sub has manually written method in generated code #2127

Closed
crwilcox opened this issue Jun 28, 2018 · 3 comments · Fixed by googleapis/gapic-generator-typescript#167
Assignees
Labels
lang: nodejs Issues specific to JavaScript or TypeScript. priority: p2 Moderately-important priority. Fix may not be included in next release. 🚨 This issue needs some love. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. yoshi

Comments

@crwilcox
Copy link

While generaing in the nodejs-pubsub package I found this code getting removed in src/v1/subscriber_client.js since it was added manually. Is this code the generator should have inserted?

    // note: editing generated code
    this.waitForReady = function(deadline, callback) {
      return subscriberStub.then(
        stub => stub.waitForReady(deadline, callback),
        callback
      );
    };
@crwilcox crwilcox added the yoshi label Jun 28, 2018
@jbolinger jbolinger added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. lang: nodejs Issues specific to JavaScript or TypeScript. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jul 6, 2018
@callmehiphop
Copy link

We actually have a couple of use cases where accessing members of the grpc client is needed. Maybe instead of stubbing more of those methods we could just add getters for the grpc clients.

@JustinBeckwith JustinBeckwith added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. and removed priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Jun 6, 2019
@JustinBeckwith JustinBeckwith added the 🚨 This issue needs some love. label Jun 27, 2019
@vchudnov-g
Copy link
Contributor

@alexander-fenster We're out of SLO for this issue. Could provide an update and/or lower the priority?

@alexander-fenster
Copy link
Contributor

The manual change is still there, but the micro-generator is supposed to fix that. Lowering the priority for now since it does not affect anyone (handled by synthtool).

@alexander-fenster alexander-fenster added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed 🚨 This issue needs some love. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Aug 5, 2019
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lang: nodejs Issues specific to JavaScript or TypeScript. priority: p2 Moderately-important priority. Fix may not be included in next release. 🚨 This issue needs some love. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. yoshi
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants