Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update all dependencies #998

Merged
merged 3 commits into from
Oct 1, 2021
Merged

fix(deps): update all dependencies #998

merged 3 commits into from
Oct 1, 2021

Conversation

summer-ji-eng
Copy link
Collaborator

@summer-ji-eng summer-ji-eng commented Oct 1, 2021

@summer-ji-eng summer-ji-eng requested a review from a team as a code owner October 1, 2021 18:12
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 1, 2021
@alexander-fenster
Copy link
Contributor

Please git rm the package-lock.json, we don't need it since we have yarn.lock.

For the errors, can we just throw the error if it's not an instance of Error? That way it won't be lost and will be visible in logs.

@summer-ji-eng
Copy link
Collaborator Author

summer-ji-eng commented Oct 1, 2021

Agree. Removed package-lock.json

throw error if error is not Instance Error

Thank you for your advice. Really helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants