fix(legacy proto load): use single proto file #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
|
Cc: @aohren |
|
Tested and it looks like this works. And there are some noticeable performance improvements. |
summer-ji-eng
approved these changes
Jul 16, 2021
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jul 16, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [2.1.0](https://www.github.com/googleapis/gapic-generator-typescript/compare/v2.0.1...v2.1.0) (2021-07-16) ### Features * support paging map response type ([#922](https://www.github.com/googleapis/gapic-generator-typescript/issues/922)) ([693732f](https://www.github.com/googleapis/gapic-generator-typescript/commit/693732f593227295e6d06e80c1d3e95ff6067671)) ### Bug Fixes * **legacy proto load:** use single proto file ([#936](https://www.github.com/googleapis/gapic-generator-typescript/issues/936)) ([41c4651](https://www.github.com/googleapis/gapic-generator-typescript/commit/41c46518d11908df0be8ef98a060a9e203017fef)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, removes proto JSON file if legacy proto options is enabled since it's not used but consumes space and takes time to generate.