Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bazel): Remove monolith Bazel rule deps [typescript] #902

Merged
merged 1 commit into from
Jun 17, 2021

Conversation

miraleung
Copy link
Contributor

This is needed for the preliminary removal of the monolith rules from googleapis' switched_rules_by_language.

@miraleung miraleung requested a review from a team as a code owner June 16, 2021 21:08
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 16, 2021
@summer-ji-eng
Copy link
Collaborator

Thanks @miraleung help on this. LGTM, but please let @alexander-fenster take a quick look.
Can I have some context on @com_google_api_codegen. I know @rules_gapic lives at https://github.com/googleapis/rules_gapic.

Another question fro @alexander-fenster is that:
We define our nodejs bazel rule at generator repo, rules_typescript_gapic. But other lanugage Java, php, csharp all lives in rules_gapic.
Try to understand the difference here. Thanks a lot.

@miraleung miraleung merged commit fff0584 into googleapis:master Jun 17, 2021
@alexander-fenster
Copy link
Contributor

The change LGTM.

@summer-ji-eng I think it makes more sense for the generator rules to be in the generator repo, because the rules and the generator are linked together (e.g. you can add a new option to the generator and to the rule implementation in the same PR). Other languages might do it in a different way though.

@miraleung
Copy link
Contributor Author

@summer-ji-eng +1 to @alexander-fenster. For the most part, other languages' rules also live in the generators, and those that don't should be cleaned up at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants