fix: yargs update by passing interface to protect the type #888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
summer-ji-eng
force-pushed
the
yargs_update
branch
from
3d2287b
to
c02b8e9
Compare
| protoc?: string | undefined; | ||
| protoDirs?: string[]; | ||
| commonProtoPath?: string; | ||
| descriptor: string | undefined; |
There was a problem hiding this comment.
This should be ? too
There was a problem hiding this comment.
Thanks for catching this up.
| export interface IArguments { | ||
| [x: string]: unknown; | ||
| outputDir?: string; | ||
| grpcServiceConfig?: string | undefined; |
There was a problem hiding this comment.
I think when you use ? it already means "can be undefined" so should be enough to say just grpcServiceConfig?: string without | undefined. Same for others.
There was a problem hiding this comment.
SG. remove undefined.
alexander-fenster
approved these changes
Jun 3, 2021
summer-ji-eng
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jun 7, 2021
🤖 I have created a release \*beep\* \*boop\* --- ### [1.4.1](https://www.github.com/googleapis/gapic-generator-typescript/compare/v1.4.0...v1.4.1) (2021-06-04) ### Bug Fixes * make request optional in all cases ([#883](https://www.github.com/googleapis/gapic-generator-typescript/issues/883)) ([f6c73fe](https://www.github.com/googleapis/gapic-generator-typescript/commit/f6c73fec21dfadc81597c6b72f6f1bf222107fdb)) * yargs update by passing interface to protect the type ([#888](https://www.github.com/googleapis/gapic-generator-typescript/issues/888)) ([e87beaa](https://www.github.com/googleapis/gapic-generator-typescript/commit/e87beaae6431b8eda9654f7be2a1d2a780183db1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With update on both package:
yargs->^16.2.0->17.0.0sinon->^10.0.0->^11.0.0see #865
The typescript can't compile on type checks with error msg:
because compiler expect
argv['outputDir'] rather thanargv.outputDir. The solution is pass in a interface to protect the type and avoid the typo by passing string in[]`.Once it merge, the #880 should pass the test.