Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: proper JSON format for GAPIC metadata file #791

Merged
merged 1 commit into from
Dec 3, 2020
Merged

fix: proper JSON format for GAPIC metadata file #791

merged 1 commit into from
Dec 3, 2020

Conversation

alexander-fenster
Copy link
Contributor

Fixing JSON format of the GAPIC metadata file. I submitted #790 to have this covered by a CI test in the future.

@alexander-fenster alexander-fenster requested a review from a team as a code owner December 2, 2020 23:14
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 2, 2020
@alexander-fenster
Copy link
Contributor Author

Cc: @martinvarelaj

vchudnov-g
vchudnov-g approved these changes Dec 2, 2020
View reviewed changes
Copy link

@vchudnov-g vchudnov-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! Apologies for not catching this when reviewing the previous PR.

@alexander-fenster alexander-fenster merged commit c06f728 into master Dec 3, 2020
@alexander-fenster alexander-fenster deleted the fix-metadata-json branch December 3, 2020 01:52
@release-please release-please bot mentioned this pull request Jan 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcoe bcoe bcoe approved these changes

@vchudnov-g vchudnov-g vchudnov-g approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexander-fenster @bcoe @vchudnov-g