Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use optional chaining for window.fetch #777

Merged
merged 2 commits into from
Nov 18, 2020
Merged

fix: use optional chaining for window.fetch #777

merged 2 commits into from
Nov 18, 2020

Conversation

alexander-fenster
Copy link
Contributor

Use window?.fetch to avoid hitting the no-undef eslint rule.

@alexander-fenster alexander-fenster requested a review from a team as a code owner November 18, 2020 16:31
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 18, 2020
@alexander-fenster alexander-fenster merged commit 01a6990 into master Nov 18, 2020
@alexander-fenster alexander-fenster deleted the chaining branch November 18, 2020 19:35
@release-please release-please bot mentioned this pull request Jan 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcoe bcoe bcoe approved these changes

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexander-fenster @bcoe @JustinBeckwith