Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x-goog-request-params #74

Closed
alexander-fenster opened this issue Oct 25, 2019 · 0 comments · Fixed by #83
Closed

x-goog-request-params #74

alexander-fenster opened this issue Oct 25, 2019 · 0 comments · Fixed by #83
Assignees
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Milestone

Comments

@alexander-fenster
Copy link
Contributor

We don't generate this:

    options.otherArgs = options.otherArgs || {};
    options.otherArgs.headers = options.otherArgs.headers || {};
    options.otherArgs.headers[
      'x-goog-request-params'
    ] = gax.routingHeader.fromParams({
      parent: request.parent,
    });

It should be pretty straightforward, it's described in https://aip.dev/client-libraries/4222.

@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Oct 26, 2019
@xiaozhenliu-gg5 xiaozhenliu-gg5 added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed triage me I really want to be triaged. labels Oct 29, 2019
@xiaozhenliu-gg5 xiaozhenliu-gg5 added this to the Beta milestone Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants