fix: make plugin parameters work properly #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
vam-google
approved these changes
Jun 24, 2020
| @@ -79,10 +79,14 @@ export class Generator { | |||
| const parameters = parameter.split(','); | |||
| for (let param of parameters) { | |||
| // remove double quote | |||
| param = param.substring(1, param.length - 1); | |||
| if (param[0] === '"' && param[param.length - 1] === '"') { | |||
There was a problem hiding this comment.
is parm.lenght guaranteed to be >=1?
There was a problem hiding this comment.
It does not matter, it won't crash in JavaScript (will return undefined).
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jun 24, 2020
🤖 I have created a release \*beep\* \*boop\* --- ### [1.0.3](https://www.github.com/googleapis/gapic-generator-typescript/compare/v1.0.2...v1.0.3) (2020-06-24) ### Bug Fixes * make plugin parameters work properly ([#574](https://www.github.com/googleapis/gapic-generator-typescript/issues/574)) ([2d77494](https://www.github.com/googleapis/gapic-generator-typescript/commit/2d774943913fbcc096b39d0786fe603994565ff9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
lukesneeringer
pushed a commit
to googleapis/googleapis
that referenced
this pull request
Jun 24, 2020
This version of the generator includes a fix to make plugin parameters work properly: googleapis/gapic-generator-typescript#574 PiperOrigin-RevId: 318086414
yoshi-automation
added a commit
to googleapis/python-recommender
that referenced
this pull request
Jul 1, 2020
This version of the generator includes a fix to make plugin parameters work properly: googleapis/gapic-generator-typescript#574 PiperOrigin-RevId: 318086414 Source-Author: Google APIs <[email protected]> Source-Date: Wed Jun 24 10:05:15 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: cbf322455cc960260c8c41d9cecaa7c4c3576ce9 Source-Link: googleapis/googleapis@cbf3224
yoshi-automation
added a commit
to googleapis/python-service-directory
that referenced
this pull request
Jul 1, 2020
This version of the generator includes a fix to make plugin parameters work properly: googleapis/gapic-generator-typescript#574 PiperOrigin-RevId: 318086414 Source-Author: Google APIs <[email protected]> Source-Date: Wed Jun 24 10:05:15 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: cbf322455cc960260c8c41d9cecaa7c4c3576ce9 Source-Link: googleapis/googleapis@cbf3224
yoshi-automation
added a commit
to googleapis/python-bigquery-reservation
that referenced
this pull request
Jul 31, 2020
This version of the generator includes a fix to make plugin parameters work properly: googleapis/gapic-generator-typescript#574 PiperOrigin-RevId: 318086414 Source-Author: Google APIs <[email protected]> Source-Date: Wed Jun 24 10:05:15 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: cbf322455cc960260c8c41d9cecaa7c4c3576ce9 Source-Link: googleapis/googleapis@cbf3224
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handling extra plugin parameters properly.
Also, adding a debug print to simplify transitioning from Docker containers to Bazel builds.