Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

common protos are added in the generated proto list #453

Closed
xiaozhenliu-gg5 opened this issue Apr 30, 2020 · 0 comments · Fixed by #455
Closed

common protos are added in the generated proto list #453

xiaozhenliu-gg5 opened this issue Apr 30, 2020 · 0 comments · Fixed by #455
Assignees
@xiaozhenliu-gg5
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@xiaozhenliu-gg5
Copy link
Contributor

The generated proto list has unneeded common protos which is in gax, but not in the generator. So including those set of protos like google.api.annotations.proto will give the below error.

UnhandledPromiseRejectionWarning: Error: ENOENT: no such file or directory, open 'protos/google/api/annotations.proto'

It’s because that the api depends on other apis which have different paths so that the commonprefix which is used to filter the protos is incorrect.

use case: nodejs-asset, nodejs-containeranalysis.
@xiaozhenliu-gg5 xiaozhenliu-gg5 added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Apr 30, 2020
@xiaozhenliu-gg5 xiaozhenliu-gg5 self-assigned this Apr 30, 2020
This was referenced May 1, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xiaozhenliu-gg5 xiaozhenliu-gg5

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove common protos in generated proto list googleapis/gapic-generator-typescript
1 participant
@xiaozhenliu-gg5