Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: naming collision on samples #1034

Merged
merged 8 commits into from
Nov 4, 2021
Merged

fix: naming collision on samples #1034

merged 8 commits into from
Nov 4, 2021

Conversation

sofisl
Copy link
Contributor

@sofisl sofisl commented Oct 29, 2021

Fixes #1000

@sofisl sofisl requested a review from a team as a code owner October 29, 2021 00:17
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 29, 2021
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Oct 29, 2021
@sofisl
Copy link
Contributor Author

sofisl commented Oct 29, 2021

I've changed the function names to all include inner in the front, or else they'll be something like functionName1. Let me know what the preference is for these names.

@bcoe
Copy link
Contributor

bcoe commented Nov 3, 2021

What if rather than innerFunctionName, we went with callFunctoinName, inner seemed slightly weird to me because it's actually the outer function from the perspective of an embeded sample.

bcoe
bcoe suggested changes Nov 3, 2021
View reviewed changes
Copy link
Contributor

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See recommendations.

@sofisl sofisl merged commit b1e522e into main Nov 4, 2021
@sofisl sofisl deleted the fixNamingCollision branch November 4, 2021 02:13
gcf-merge-on-green bot pushed a commit that referenced this pull request Nov 8, 2021
@release-please
chore: release 2.10.0 (#1048)
8ed0626 
🤖 I have created a release \*beep\* \*boop\*
---
## [2.10.0](https://www.github.com/googleapis/gapic-generator-typescript/compare/v2.9.0...v2.10.0) (2021-11-08)


### Features

* add dynamic routing to generated client ([#1042](https://www.github.com/googleapis/gapic-generator-typescript/issues/1042)) ([afe38bf](https://www.github.com/googleapis/gapic-generator-typescript/commit/afe38bf0b36e50240684e3806f7505c009611a3f))


### Bug Fixes

* naming collision on samples ([#1034](https://www.github.com/googleapis/gapic-generator-typescript/issues/1034)) ([b1e522e](https://www.github.com/googleapis/gapic-generator-typescript/commit/b1e522e3f6b65766836db9f12a00bf531d71ed35))
* remove deprecated fields ([#1036](https://www.github.com/googleapis/gapic-generator-typescript/issues/1036)) ([dcdb895](https://www.github.com/googleapis/gapic-generator-typescript/commit/dcdb89599857db1715be3438a0a571ff3b05d6ce))
* replace empty objects with curly brackets instead of strings ([#1041](https://www.github.com/googleapis/gapic-generator-typescript/issues/1041)) ([b6c3957](https://www.github.com/googleapis/gapic-generator-typescript/commit/b6c395725d7b0d01e0dbed211fafbaf5764f4171))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@release-please release-please bot mentioned this pull request Jan 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhinkel fhinkel fhinkel approved these changes

@bcoe bcoe bcoe approved these changes

@alexander-fenster alexander-fenster alexander-fenster approved these changes

@summer-ji-eng summer-ji-eng summer-ji-eng approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(sample-gen): do not use reserved words
5 participants
@sofisl @bcoe @fhinkel @alexander-fenster @summer-ji-eng