-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce CommitSigner interface #442
Conversation
77625f8
to
95e74ea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable to me. I think we should probably have a concrete signer in this repository eventually, once we've figured out the best option for this.
@@ -44,6 +60,9 @@ export async function createCommit( | |||
message, | |||
tree: treeSha, | |||
parents: [refHead], | |||
signature, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you can find the REST documentation in the GitHub API, adding it here as a comment would be useful.
I'm interested to know what options we have available to us for a signing algorithm (I'm hoping we might be able to use something other than GPG).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a link to the create commit API docs. It looks like only PGP is supported for this API
Towards #337
This introduces an interface to allow providing a commit signer, but does not include any implementation.