Simplify some Ptr operations #2577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 9, 2025
joshlf
force-pushed
the
I1945c8e554dd80a0475462d0dc5e0ae1eb2e9ac4
branch
from
5774b01 to
30ab41e
Compare
joshlf
changed the title
jswrenn
approved these changes
Jun 9, 2025
jswrenn
reviewed
Jun 9, 2025
| // those terms. | ||
|
|
||
| use core::{marker::PhantomData, ops::Range, ptr::NonNull}; | ||
| use core::{marker::PhantomData, mem, ops::Range, ptr::NonNull}; |
There was a problem hiding this comment.
You'll need a #[cfg(doc)] use core::ptr::NonNull; to get CI to pass.
joshlf
force-pushed
the
I1945c8e554dd80a0475462d0dc5e0ae1eb2e9ac4
branch
from
30ab41e to
077c7bd
Compare
Some raw pointer casts now have the signature `fn(PtrInner) -> PtrInner` instead of `fn(PtrInner) -> NonNull`. Simplify the implementations of some `Ptr` methods. Co-authored-by: Jack Wrenn <[email protected]> gherrit-pr-id: I1945c8e554dd80a0475462d0dc5e0ae1eb2e9ac4
joshlf
force-pushed
the
I1945c8e554dd80a0475462d0dc5e0ae1eb2e9ac4
branch
from
077c7bd to
a6f8897
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2577 +/- ##
==========================================
+ Coverage 88.85% 88.91% +0.05%
==========================================
Files 20 20
Lines 5312 5313 +1
==========================================
+ Hits 4720 4724 +4
+ Misses 592 589 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some raw pointer casts now have the signature
fn(PtrInner) -> PtrInnerinstead of
fn(PtrInner) -> NonNull. Simplify the implementations ofsome
Ptrmethods.Co-authored-by: Jack Wrenn [email protected]
This PR is on branch transmute-ref-dst.