-
Notifications
You must be signed in to change notification settings - Fork 27
Upgrade all dependencies #932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request upgrades a large number of dependencies across the project. The changes are mostly in Cargo.toml and Cargo.lock files, which is expected for this kind of update. I've reviewed the code changes made to adapt to new APIs, and they seem correct. This includes the switch from doc_auto_cfg to doc_cfg due to Rust toolchain updates, and the adaptation to the new otcrypto_sha2_* API in crates/runner-opentitan/src/crypto/hash.rs following the opentitan submodule update. The update of mdbook and assemblyscript versions are also correctly handled. Overall, this is a solid dependency upgrade.
This was changed by the bump in google#932.
This was changed by the bump in google#932.
This was changed by the bump in #932.
This is a follow-up of google#932 now that rust-lang/rust#146974 has been addressed.
This is a follow-up of google#932 now that rust-lang/rust#146974 has been addressed.
This is a follow-up of google#932 now that rust-lang/rust#146974 has been addressed.
This is a follow-up of google#932 now that rust-lang/rust#146974 has been addressed.
This is a follow-up of google#932 now that rust-lang/rust#146974 has been addressed.
This is a follow-up of google#932.
This is a follow-up of google#932.
This is a follow-up of google#932.
We're holding 2 things behind: