Skip to content

Conversation

@ia0
Copy link
Member

@ia0 ia0 commented Oct 3, 2025

We're holding 2 things behind:

@ia0 ia0 added the for:maintainability Improves maintainers life label Oct 3, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades a large number of dependencies across the project. The changes are mostly in Cargo.toml and Cargo.lock files, which is expected for this kind of update. I've reviewed the code changes made to adapt to new APIs, and they seem correct. This includes the switch from doc_auto_cfg to doc_cfg due to Rust toolchain updates, and the adaptation to the new otcrypto_sha2_* API in crates/runner-opentitan/src/crypto/hash.rs following the opentitan submodule update. The update of mdbook and assemblyscript versions are also correctly handled. Overall, this is a solid dependency upgrade.

@ia0 ia0 merged commit 2512378 into google:main Oct 3, 2025
22 checks passed
@ia0 ia0 deleted the upgrade branch October 3, 2025 10:29
ia0 added a commit to ia0/wasefire that referenced this pull request Oct 3, 2025
ia0 added a commit to ia0/wasefire that referenced this pull request Oct 3, 2025
ia0 added a commit that referenced this pull request Oct 3, 2025
ia0 added a commit to ia0/wasefire that referenced this pull request Oct 7, 2025
This is a follow-up of google#932 now that rust-lang/rust#146974 has been
addressed.
ia0 added a commit to ia0/wasefire that referenced this pull request Oct 7, 2025
This is a follow-up of google#932 now that rust-lang/rust#146974 has been
addressed.
ia0 added a commit to ia0/wasefire that referenced this pull request Oct 7, 2025
This is a follow-up of google#932 now that rust-lang/rust#146974 has been
addressed.
ia0 added a commit to ia0/wasefire that referenced this pull request Oct 7, 2025
This is a follow-up of google#932 now that rust-lang/rust#146974 has been
addressed.
ia0 added a commit to ia0/wasefire that referenced this pull request Oct 8, 2025
This is a follow-up of google#932 now that rust-lang/rust#146974 has been
addressed.
ia0 added a commit to ia0/wasefire that referenced this pull request Oct 8, 2025
This is a follow-up of google#932.
@ia0 ia0 mentioned this pull request Oct 8, 2025
ia0 added a commit to ia0/wasefire that referenced this pull request Oct 8, 2025
This is a follow-up of google#932.
ia0 added a commit to ia0/wasefire that referenced this pull request Oct 8, 2025
This is a follow-up of google#932.
ia0 added a commit that referenced this pull request Oct 8, 2025
This is a follow-up of #932.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

for:maintainability Improves maintainers life

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants