-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check ct.sym first before falling back to jrt #318
Conversation
@cushon I think this should fix the issue when using a Do you know if it's written down somewhere how I would go about testing this? I assume I'd need to get |
Thanks for this!
I think those docs are out of date, the approach I've used is: bazelbuild/java_tools#43 (comment) |
Since Turbine is used via a GraalVM native image in Bazel, jrt is not enabled, so looking up the bootclasspath that way doesn't work. As of Java 22, ct.sym contains signatures for all supported JDKs, so there is no need to look in jrt. Partial fix for bazelbuild/bazel#21895
d45f0a3
to
2a48a7d
Compare
@cushon Thanks, your linked guide worked for testing this, though I had some difficulty with bazelbuild/bazel#21935. Using this patch, I can build code with I think the test failure might be unrelated, |
Since Turbine is used via a GraalVM native image in Bazel, jrt is not enabled, so looking up the bootclasspath that way doesn't work. As of Java 22, ct.sym contains signatures for all supported JDKs, so there is no need to look in jrt. Partial fix for bazelbuild/bazel#21895 Fixes #318 FUTURE_COPYBARA_INTEGRATE_REVIEW=#318 from srdo-humio:stig/check-ct-sym-first 2a48a7d PiperOrigin-RevId: 622308437
Since Turbine is used via a GraalVM native image in Bazel, jrt is not enabled, so looking up the bootclasspath that way doesn't work. As of Java 22, ct.sym contains signatures for all supported JDKs, so there is no need to look in jrt. Partial fix for bazelbuild/bazel#21895 Fixes #318 FUTURE_COPYBARA_INTEGRATE_REVIEW=#318 from srdo-humio:stig/check-ct-sym-first 2a48a7d PiperOrigin-RevId: 622308437
Since Turbine is used via a GraalVM native image in Bazel, jrt is not enabled, so looking up the bootclasspath that way doesn't work. As of Java 22, ct.sym contains signatures for all supported JDKs, so there is no need to look in jrt. Partial fix for bazelbuild/bazel#21895 Fixes #318 FUTURE_COPYBARA_INTEGRATE_REVIEW=#318 from srdo-humio:stig/check-ct-sym-first 2a48a7d PiperOrigin-RevId: 622308437
Since Turbine is used via a GraalVM native image in Bazel, jrt is not enabled, so looking up the bootclasspath that way doesn't work. As of Java 22, ct.sym contains signatures for all supported JDKs, so there is no need to look in jrt. Partial fix for bazelbuild/bazel#21895 Fixes #318 FUTURE_COPYBARA_INTEGRATE_REVIEW=#318 from srdo-humio:stig/check-ct-sym-first 2a48a7d PiperOrigin-RevId: 622308437
Since Turbine is used via a GraalVM native image in Bazel, jrt is not enabled, so looking up the bootclasspath that way doesn't work. As of Java 22, ct.sym contains signatures for all supported JDKs, so there is no need to look in jrt. Partial fix for bazelbuild/bazel#21895 Fixes #318 FUTURE_COPYBARA_INTEGRATE_REVIEW=#318 from srdo-humio:stig/check-ct-sym-first 2a48a7d PiperOrigin-RevId: 622308437
Since Turbine is used via a GraalVM native image in Bazel, jrt is not enabled, so looking up the bootclasspath that way doesn't work. As of Java 22, ct.sym contains signatures for all supported JDKs, so there is no need to look in jrt. Partial fix for bazelbuild/bazel#21895 Fixes #318 FUTURE_COPYBARA_INTEGRATE_REVIEW=#318 from srdo-humio:stig/check-ct-sym-first 2a48a7d PiperOrigin-RevId: 622308437
Since Turbine is used via a GraalVM native image in Bazel, jrt is not enabled, so looking up the bootclasspath that way doesn't work. As of Java 22, ct.sym contains signatures for all supported JDKs, so there is no need to look in jrt. Partial fix for bazelbuild/bazel#21895 Fixes #318 FUTURE_COPYBARA_INTEGRATE_REVIEW=#318 from srdo-humio:stig/check-ct-sym-first 2a48a7d PiperOrigin-RevId: 622308437
Since Turbine is used via a GraalVM native image in Bazel, jrt is not enabled, so looking up the bootclasspath that way doesn't work. As of Java 22, ct.sym contains signatures for all supported JDKs, so there is no need to look in jrt. Partial fix for bazelbuild/bazel#21895 Fixes #318 FUTURE_COPYBARA_INTEGRATE_REVIEW=#318 from srdo-humio:stig/check-ct-sym-first 2a48a7d PiperOrigin-RevId: 622308437
Since Turbine is used via a GraalVM native image in Bazel, jrt is not enabled, so looking up the bootclasspath that way doesn't work. As of Java 22, ct.sym contains signatures for all supported JDKs, so there is no need to look in jrt. Partial fix for bazelbuild/bazel#21895 Fixes #318 FUTURE_COPYBARA_INTEGRATE_REVIEW=#318 from srdo-humio:stig/check-ct-sym-first 2a48a7d PiperOrigin-RevId: 622308437
Since Turbine is used via a GraalVM native image in Bazel, jrt is not enabled, so looking up the bootclasspath that way doesn't work. As of Java 22, ct.sym contains signatures for all supported JDKs, so there is no need to look in jrt. Partial fix for bazelbuild/bazel#21895 Fixes #318 FUTURE_COPYBARA_INTEGRATE_REVIEW=#318 from srdo-humio:stig/check-ct-sym-first 2a48a7d PiperOrigin-RevId: 622308437
Since Turbine is used via a GraalVM native image in Bazel, jrt is not enabled, so looking up the bootclasspath that way doesn't work. As of Java 22, ct.sym contains signatures for all supported JDKs, so there is no need to look in jrt. Partial fix for bazelbuild/bazel#21895 Fixes #318 FUTURE_COPYBARA_INTEGRATE_REVIEW=#318 from srdo-humio:stig/check-ct-sym-first 2a48a7d PiperOrigin-RevId: 622308437
Since Turbine is used via a GraalVM native image in Bazel, jrt is not enabled, so looking up the bootclasspath that way doesn't work. As of Java 22, ct.sym contains signatures for all supported JDKs, so there is no need to look in jrt. Partial fix for bazelbuild/bazel#21895 Fixes #318 FUTURE_COPYBARA_INTEGRATE_REVIEW=#318 from srdo-humio:stig/check-ct-sym-first 2a48a7d PiperOrigin-RevId: 622308437
Since Turbine is used via a GraalVM native image in Bazel, jrt is not enabled, so looking up the bootclasspath that way doesn't work. As of Java 22, ct.sym contains signatures for all supported JDKs, so there is no need to look in jrt. Partial fix for bazelbuild/bazel#21895 Fixes #318 FUTURE_COPYBARA_INTEGRATE_REVIEW=#318 from srdo-humio:stig/check-ct-sym-first 2a48a7d PiperOrigin-RevId: 622308437
Since Turbine is used via a GraalVM native image in Bazel, jrt is not enabled, so looking up the bootclasspath that way doesn't work. As of Java 22, ct.sym contains signatures for all supported JDKs, so there is no need to look in jrt. Partial fix for bazelbuild/bazel#21895 Fixes #318 FUTURE_COPYBARA_INTEGRATE_REVIEW=#318 from srdo-humio:stig/check-ct-sym-first 2a48a7d PiperOrigin-RevId: 622308437
Since Turbine is used via a GraalVM native image in Bazel, jrt is not enabled, so looking up the bootclasspath that way doesn't work. As of Java 22, ct.sym contains signatures for all supported JDKs, so there is no need to look in jrt. Partial fix for bazelbuild/bazel#21895 Fixes #318 FUTURE_COPYBARA_INTEGRATE_REVIEW=#318 from srdo-humio:stig/check-ct-sym-first 2a48a7d PiperOrigin-RevId: 622308437
Since Turbine is used via a GraalVM native image in Bazel, jrt is not enabled, so looking up the bootclasspath that way doesn't work. As of Java 22, ct.sym contains signatures for all supported JDKs, so there is no need to look in jrt. Partial fix for bazelbuild/bazel#21895 Fixes #318 FUTURE_COPYBARA_INTEGRATE_REVIEW=#318 from srdo-humio:stig/check-ct-sym-first 2a48a7d PiperOrigin-RevId: 622308437
Since Turbine is used via a GraalVM native image in Bazel, jrt is not enabled, so looking up the bootclasspath that way doesn't work. As of Java 22, ct.sym contains signatures for all supported JDKs, so there is no need to look in jrt. Partial fix for bazelbuild/bazel#21895 Fixes #318 FUTURE_COPYBARA_INTEGRATE_REVIEW=#318 from srdo-humio:stig/check-ct-sym-first 2a48a7d PiperOrigin-RevId: 622308437
Since Turbine is used via a GraalVM native image in Bazel, jrt is not enabled, so looking up the bootclasspath that way doesn't work. As of Java 22, ct.sym contains signatures for all supported JDKs, so there is no need to look in jrt. Partial fix for bazelbuild/bazel#21895 Fixes #318 FUTURE_COPYBARA_INTEGRATE_REVIEW=#318 from srdo-humio:stig/check-ct-sym-first 2a48a7d PiperOrigin-RevId: 622308437
Since Turbine is used via a GraalVM native image in Bazel, jrt is not enabled, so looking up the bootclasspath that way doesn't work. As of Java 22, ct.sym contains signatures for all supported JDKs, so there is no need to look in jrt. Partial fix for bazelbuild/bazel#21895 Fixes #318 FUTURE_COPYBARA_INTEGRATE_REVIEW=#318 from srdo-humio:stig/check-ct-sym-first 2a48a7d PiperOrigin-RevId: 622308437
Thanks, I had started the process to import this and it got stuck, I think I have unstuck it now. The test failure I saw was unrelated and only on JDK EA versions, and should have been resolved by 74c2c36. |
Since Turbine is used via a GraalVM native image in Bazel, jrt is not enabled, so looking up the bootclasspath that way doesn't work.
As of Java 22, ct.sym contains signatures for all supported JDKs, so there is no need to look in jrt.
Partial fix for bazelbuild/bazel#21895