Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding additional context to TLS server test names #904

Open
duncangreene opened this issue Oct 18, 2024 · 1 comment
Open

Consider adding additional context to TLS server test names #904

duncangreene opened this issue Oct 18, 2024 · 1 comment
Assignees
Labels
test A new test case or issue identified with a test

Comments

@duncangreene
Copy link

duncangreene commented Oct 18, 2024

What is the problem your feature is trying to solve?
Multiple services on a device can run using differing versions of TLS. For example on a single device, the version and ciphers used by MQTT/TLS may be completely different from the version and ciphers used by HTTP/TLS.

The below shows a device that offers TLS v1.2 and TLS v1.3 on port 8009, but only TLS v1.2 on port 8443.

Image

By the looks of the code I believe the security.tls.v*_*_server tests are specifically targeted at the service listening on port 443 on the DUT, and I wonder whether there would be merit in tightening the test name to reflect this? It may avoid the user incorrectly assuming that all services on the DUT offer 'TLS v1.3' when they read the result in the report for security.tls.v1_3_server (which as we can see above for 8443, isn't the case).

Image

Describe the solution you think would solve the problem
Consider renaming to security.tcp443.tls.v*_*_server or similar.

Additional context
This would provide extensibility in the test namespace for additional TLS server tests to be carried out and individually reported against other ports.

  • security.tcp443.tls.v1_2_server
  • security.tcp443.tls.v1_3_server
  • security.tcp993.tls.v1_2_server
  • security.tcp993.tls.v1_3_server
  • security.tcp8443.tls.v1_2_server
  • security.tcp8443.tls.v1_3_server
  • security.tcp8883.tls.v1_2_server
  • security.tcp8883.tls.v1_3_server
@jboddey jboddey self-assigned this Oct 28, 2024
@jboddey
Copy link
Collaborator

jboddey commented Nov 6, 2024

I agree that we need to consider varying TLS implementations for different services - I am not sure the proposed test names are the right way of going about it - I will think further on another solution.

@jboddey jboddey added test A new test case or issue identified with a test and removed request labels Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test A new test case or issue identified with a test
Projects
None yet
Development

No branches or pull requests

2 participants