Issue / 9364 Filter Out ACR Saved Metric Items Upon conversionReporting Feature Flag Disable

[10upsimon]

Summary

Addresses issue:

• Filter out ACR metric items from saved ones if feature flag is disabled #9364

Relevant technical choices

• Define new constant that holds non ACR KMW's only.
• Update key-metrics user data store, filter returned user selected KMW's in getKeyMetrics selector to exclude saved ACR items if the conversionReporting feature flag is not present.
• Add test cases for user selected ACR KMW's with and without conversionReporting feature flag present.

PR Author Checklist

• My code is tested and passes existing unit tests.
• My code has an appropriate set of unit tests which all pass.
• My code is backward-compatible with WordPress 5.2 and PHP 7.4.
• My code follows the WordPress coding standards.
• My code has proper inline documentation.
• I have added a QA Brief on the issue linked above.
• I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

• Run the code.
• Ensure the acceptance criteria are satisfied.
• Reassess the implementation with the IB.
• Ensure no unrelated changes are included.
• Ensure CI checks pass.
• Check Storybook where applicable.
• Ensure there is a QA Brief.
• Ensure there are no unexpected significant changes to file sizes.

Merge Reviewer Checklist

• Ensure the PR has the correct target branch.
• Double-check that the PR is okay to be merged.
• Ensure the corresponding issue has a ZenHub release assigned.
• Add a changelog message to the issue.

[github-actions]

Build files for 3a980e2 are ready:

• Download development build
• Download production build

[github-actions]

Size Change: +1.53 kB (+0.08%)

Total Size: 1.84 MB

Filename	Size	Change
./dist/assets/js/31-********************.js	0 B	-2.76 kB (removed)	🏆
./dist/assets/js/32-********************.js	2.76 kB	+503 B (+22.32%)	🚨
./dist/assets/js/33-********************.js	2.25 kB	-1.39 kB (-38.14%)	🎉
./dist/assets/js/34-********************.js	3.64 kB	+2.71 kB (+289.73%)	🆘
./dist/assets/js/35-********************.js	935 B	+42 B (+4.7%)	🔍
./dist/assets/js/36-********************.js	891 B	-2.23 kB (-71.41%)	🏆
./dist/assets/js/googlesitekit-activation-********************.js	23.9 kB	+19 B (+0.08%)
./dist/assets/js/googlesitekit-ad-blocking-recovery-********************.js	70.2 kB	+11 B (+0.02%)
./dist/assets/js/googlesitekit-adminbar-********************.js	34.7 kB	-21 B (-0.06%)
./dist/assets/js/googlesitekit-api-********************.js	10 kB	+16 B (+0.16%)
./dist/assets/js/googlesitekit-components-gm2-********************.js	5.96 kB	+4 B (+0.07%)
./dist/assets/js/googlesitekit-datastore-forms-********************.js	8.95 kB	+1 B (+0.01%)
./dist/assets/js/googlesitekit-datastore-location-********************.js	2.08 kB	+1 B (+0.05%)
./dist/assets/js/googlesitekit-datastore-site-********************.js	20.4 kB	+20 B (+0.1%)
./dist/assets/js/googlesitekit-datastore-ui-********************.js	9.94 kB	+17 B (+0.17%)
./dist/assets/js/googlesitekit-datastore-user-********************.js	26.3 kB	+45 B (+0.17%)
./dist/assets/js/googlesitekit-entity-dashboard-********************.js	81.6 kB	+36 B (+0.04%)
./dist/assets/js/googlesitekit-main-dashboard-********************.js	155 kB	+13 B (+0.01%)
./dist/assets/js/googlesitekit-modules-********************.js	22 kB	+16 B (+0.07%)
./dist/assets/js/googlesitekit-modules-ads-********************.js	32.8 kB	+24 B (+0.07%)
./dist/assets/js/googlesitekit-modules-adsense-********************.js	123 kB	+19 B (+0.02%)
./dist/assets/js/googlesitekit-modules-analytics-4-********************.js	173 kB	+77 B (+0.04%)
./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js	22.5 kB	-6 B (-0.03%)
./dist/assets/js/googlesitekit-modules-reader-revenue-manager-********************.js	21.9 kB	+18 B (+0.08%)
./dist/assets/js/googlesitekit-modules-search-console-********************.js	59 kB	+16 B (+0.03%)
./dist/assets/js/googlesitekit-modules-tagmanager-********************.js	32 kB	+9 B (+0.03%)
./dist/assets/js/googlesitekit-notifications-********************.js	22.4 kB	+18 B (+0.08%)
./dist/assets/js/googlesitekit-settings-********************.js	125 kB	+24 B (+0.02%)
./dist/assets/js/googlesitekit-splash-********************.js	86.3 kB	+9 B (+0.01%)
./dist/assets/js/googlesitekit-user-input-********************.js	60.8 kB	+17 B (+0.03%)
./dist/assets/js/googlesitekit-vendor-********************.js	321 kB	-4 B (0%)
./dist/assets/js/googlesitekit-widgets-********************.js	89.1 kB	+116 B (+0.13%)
./dist/assets/js/googlesitekit-wp-dashboard-********************.js	62.1 kB	+11 B (+0.02%)
./dist/assets/js/runtime-********************.js	1.3 kB	-2 B (-0.15%)
./dist/assets/js/37-********************.js	3.12 kB	+3.12 kB (new file)	🆕
./dist/assets/js/googlesitekit-modules-sign-in-with-google-********************.js	1.01 kB	+1.01 kB (new file)	🆕

ℹ️ View Unchanged

Filename	Size
./dist/assets/css/googlesitekit-admin-css-********************.min.css	58 kB
./dist/assets/css/googlesitekit-adminbar-css-********************.min.css	11.8 kB
./dist/assets/css/googlesitekit-authorize-application-css-********************.min.css	846 B
./dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css	8.2 kB
./dist/assets/js/analytics-advanced-tracking-********************.js	901 B
./dist/assets/js/googlesitekit-components-gm3-********************.js	10.1 kB
./dist/assets/js/googlesitekit-consent-mode-********************.js	25.6 kB
./dist/assets/js/googlesitekit-data-********************.js	2.37 kB
./dist/assets/js/googlesitekit-events-provider-contact-form-7-********************.js	646 B
./dist/assets/js/googlesitekit-events-provider-easy-digital-downloads-********************.js	624 B
./dist/assets/js/googlesitekit-events-provider-mailchimp-********************.js	630 B
./dist/assets/js/googlesitekit-events-provider-ninja-forms-********************.js	712 B
./dist/assets/js/googlesitekit-events-provider-optin-monster-********************.js	675 B
./dist/assets/js/googlesitekit-events-provider-popup-maker-********************.js	634 B
./dist/assets/js/googlesitekit-events-provider-woocommerce-********************.js	657 B
./dist/assets/js/googlesitekit-events-provider-wpforms-********************.js	633 B
./dist/assets/js/googlesitekit-i18n-********************.js	3.93 kB
./dist/assets/js/googlesitekit-polyfills-********************.js	377 B

_{compressed-size-action}