Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set linker object in gtag within the Ads tag #9947

Open
1 task
nfmohit opened this issue Dec 30, 2024 · 1 comment
Open
1 task

Set linker object in gtag within the Ads tag #9947

nfmohit opened this issue Dec 30, 2024 · 1 comment
Labels
Module: Ads Google Ads module related issues P2 Low priority PHP Type: Enhancement Improvement of an existing feature

Comments

@nfmohit
Copy link
Collaborator

nfmohit commented Dec 30, 2024

Feature Description

Unlike Analytics, the Ads module does not set a linker object in gtag within its tag. This should be addressed in such a way so that when both Analytics and Ads modules are connected, only one linker object is set.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation Brief

Test Coverage

QA Brief

Changelog entry

@nfmohit nfmohit added P2 Low priority Type: Enhancement Improvement of an existing feature PHP Module: Ads Google Ads module related issues labels Dec 30, 2024
@aaemnnosttv
Copy link
Collaborator

This seems to have been missed in #8518 as the linker is added to the Ads tag for AMP but not for web. I think this should probably be applied in GTag rather than specific tags since it appears to be a top-level setting. It was only included as part of the tag-level configuration for GA4 for backwards compatibility since this is where all gtag options were filterable originally. Even then, it was pulled out and added as a set rather than being included in a tag config command. Since Ads was initially implemented via Analytics this would have covered both, but now that they're independent, it can be missing if only Ads is connected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Module: Ads Google Ads module related issues P2 Low priority PHP Type: Enhancement Improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants