Sign in with Google user registration notification does not always get dismissed

[wpdarren]

Bug Description

In edit mode, when the user has not enabled the user registration, a notification appears as expected but when I clicked on 'Got it' the notification remains. It's only when I click a second time that it gets dismissed.

It doesn't always happen though. it is a little sporadic in its behaviour.

Fast forward in the attached video to around 1:25 to see the issue in action.

Got.it.in.edit.mode.mov

Further context on dismissItem

It seems the dismissItem action being dispatched when the wp_googlesitekitpersistent_dismissed_items is either empty or removed causes two separate wp_googlesitekitpersistent_dismissed_items to be created. Two requests are made, one being legitimate and another being a bogus entry where slug is evaluated as true rather than a string:

If this request is processed by the server first, an empty wp_googlesitekitpersistent_dismissed_items is retrieved constantly:

If it's not the first entry then everything is normal.

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

• Only one request should be made when dispatching dismissItem, and it should be made where slug is a string.
• Checks should be added to the dismissItem action such that only a string is a valid slug to prevent this issue in the future.

Implementation Brief

Test Coverage

QA Brief

Changelog entry