Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement haveFirstPartyModeSettingsChanged Selector and resetFirstPartyModeSettings Action #9688

Open
1 task
hussain-t opened this issue Nov 14, 2024 · 1 comment
Labels
P0 High priority Team M Issues for Squad 2 Type: Enhancement Improvement of an existing feature

Comments

@hussain-t
Copy link
Collaborator

hussain-t commented Nov 14, 2024

Feature Description

Develop a selector and action in the First-party mode datastore to handle the settings state:

  • haveFirstPartyModeSettingsChanged(): A selector to check if current settings differ from saved settings.
  • resetFirstPartyModeSettings(): An action to revert any changes, restoring settings to their saved state.

These should integrate with existing rollback and validation processes of Analytics and Ads settings.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • A haveFirstPartyModeSettingsChanged selector should be created to compare the current First-party mode settings with the saved settings, returning true if there are unsaved changes and false if the current settings match the saved settings.
  • A resetFirstPartyModeSettings action should be created to reset any unsaved changes in the First-party mode settings, restoring them to the last saved state.
  • The resetFirstPartyModeSettings action should be called within the rollbackChanges process of both Analytics and Ads settings to ensure any unsaved changes are discarded when rolling back.
  • The haveFirstPartyModeSettingsChanged selector should be used within the validateHaveSettingsChanged function of both Analytics and Ads settings to confirm if there are changes that need validation before saving.
  • The submit button on both the Analytics and Ads settings screens should update its text to “Confirm changes” when there are validated changes, indicating that the modified settings will be saved.

Implementation Brief

Test Coverage

QA Brief

Changelog entry

@hussain-t hussain-t added P0 High priority Type: Enhancement Improvement of an existing feature Team M Issues for Squad 2 labels Nov 14, 2024
@hussain-t hussain-t assigned hussain-t and unassigned hussain-t Nov 14, 2024
@techanvil techanvil self-assigned this Nov 14, 2024
@techanvil
Copy link
Collaborator

AC ✅

@techanvil techanvil removed their assignment Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 High priority Team M Issues for Squad 2 Type: Enhancement Improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants