Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ads PAX Beta - Update Initial Ads Setup Screen, Remove Manual AW-ID Input & Auto Trigger PAX Application #9426

Open
1 task
10upsimon opened this issue Sep 27, 2024 · 3 comments
Labels
javascript Pull requests that update Javascript code Module: Ads Google Ads module related issues Next Up Issues to prioritize for definition P0 High priority Team S Issues for Squad 1 Type: Enhancement Improvement of an existing feature

Comments

@10upsimon
Copy link
Collaborator

10upsimon commented Sep 27, 2024

Feature Description

For users enrolled in the Beta phase of the Ads PAX integration (those using the mini plugin), the Ads module setup flow should disallow for manual AW-ID input and enter immediately (and automatically) into the PAX application setup flow, simulating the current scenario where a user (with the adsPAX feature enabled) would click the "Create an account" CTA button.

Site Kit by Google Dashboard ‹ sitekit 10uplabs com — WordPress 2024-09-27 at 11 20 36 AM


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • For users enrolled in the Beta phase of the Ads PAX integration (those making use of the mini plugin):
    • The ability to manually input an AW-ID should also be removed, and the entire settings field along with it's label and the preceding instructional paragraph should be removed.
    • The PAX application flow should be triggered automatically on the initial setup screen of the Ads module, not via the existing "Create an account" CTA, therefore this CTA should be removed as well, along with the "additional permissions text", essentially taking the user to the OAuth flow immediately (or triggering the PAX app if the oAuth role is already granted)
  • Both of these changes should only be effected when the adsPAX feature flag is enabled

Implementation Brief

Test Coverage

QA Brief

Changelog entry

@10upsimon 10upsimon added javascript Pull requests that update Javascript code Module: Ads Google Ads module related issues P0 High priority Team S Issues for Squad 1 Type: Enhancement Improvement of an existing feature labels Sep 27, 2024
@zutigrm zutigrm self-assigned this Sep 27, 2024
@zutigrm
Copy link
Collaborator

zutigrm commented Sep 27, 2024

@10upsimon Almost there, just small point for clarity:

The ability to manually input an AW-ID should also be removed

Let's clarify what exactly should happen - should input be disabled, or completely hidden together with the Create an account CTA? Since disabling ability to manually input data can have several outcomes

@zutigrm zutigrm assigned 10upsimon and unassigned zutigrm Sep 27, 2024
@binnieshah binnieshah added the Next Up Issues to prioritize for definition label Sep 27, 2024
@10upsimon
Copy link
Collaborator Author

Let's clarify what exactly should happen

@zutigrm it should disappear entirely, I will clarify.

@10upsimon 10upsimon assigned zutigrm and unassigned 10upsimon Sep 27, 2024
@zutigrm
Copy link
Collaborator

zutigrm commented Sep 27, 2024

Thanks @10upsimon AC ✅

@zutigrm zutigrm removed their assignment Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code Module: Ads Google Ads module related issues Next Up Issues to prioritize for definition P0 High priority Team S Issues for Squad 1 Type: Enhancement Improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

3 participants