Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily Hidden badge UX issues #9421

Open
2 tasks
kelvinballoo opened this issue Sep 26, 2024 · 1 comment
Open
2 tasks

Temporarily Hidden badge UX issues #9421

kelvinballoo opened this issue Sep 26, 2024 · 1 comment
Labels
Module: Analytics Google Analytics module related issues P1 Medium priority Team M Issues for Squad 2 Type: Bug Something isn't working

Comments

@kelvinballoo
Copy link
Collaborator

kelvinballoo commented Sep 26, 2024

Bug Description

2 Issues to highlight:

  • When we click on the 'i' for the 'Temporarily hidden' badge, it will check on and off the corresponding checkbox and also bring up the tooltip. It's a bad UX.

    9096.clicking.on.temporary.hide.mov
  • On mobile, the experience is a bit odd as well. It seems like when we tap and lift off our finger, the tooltip will appear and disappear. It seems like for the tooltip to stay, we need to keep our finger there.

    RPReplay_Final1727358104.MP4

Steps to reproduce

  1. Enable audience segmentation feature and enable the visitor groups. Add the non Site Kit created audience to audience tile like "All visitors" and also a SK created audience "New Visitors"

  2. In the tester plugin, set Analytics > Force Analytics report data to Zero. Also, set Analytics Partial Data > Force Analytics audience partial data state to last-28-days. Save changes.

  3. Go to Site Kit dashboard and to audience tile section. You will see the tile in collecting data status with the link to hide the tile temporarily ( "Temporarily hide" ).

  4. Click on the "Temporarily hide" link for "All Visitors", that will hide the tile.

  5. Open the audience selection panel. There should be a "Temporarily Hidden" badge with a tooltip.

Click on the 'i' icon for the "Temporarily Hidden" badge and you will notice it will check on and off the checkbox.
Also, when tapping on mobile, the UX is weird. The tooltip only appears as long as we press the tooltip. If we lift the finger, it's gone.

Screenshots

Additional Context

  • PHP Version:
  • OS: [e.g. iOS]
  • Browser: [e.g. chrome, safari]
  • Plugin Version: [e.g. 22]
  • Device: [e.g. iPhone6]

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • Clicking on a badge in the Audience Selection Panel should not toggle the item's checkbox.
  • Clicking on the information icon in the "Temporarily hidden" badge should show the tooltip for the icon. It should not be necessary to hold the touch on a mobile device as per the bug description.

Implementation Brief

Note, this issue only needs to tackle the GM2 version of Checkbox - we can port the changes across to the GM3 version to keep them aligned in a separate issue, #9423.

Test Coverage

  • Add test cases for the badge rendering to the Checkbox test suite.
  • Add instances of checkboxes with badges to the Checkbox story.
  • Fix any failing tests.

QA Brief

  • Follow the steps to reproduce and verify that the reported issues no longer exist.

Changelog entry

@nfmohit
Copy link
Collaborator

nfmohit commented Sep 26, 2024

IB ✅

@nfmohit nfmohit removed their assignment Sep 26, 2024
@ivonac4 ivonac4 added the Team M Issues for Squad 2 label Sep 27, 2024
@nfmohit nfmohit assigned nfmohit and unassigned nfmohit Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Module: Analytics Google Analytics module related issues P1 Medium priority Team M Issues for Squad 2 Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants