Remove use of non-existent WithRegistrySetup.features prop

[techanvil]

Feature Description

A number of stories have been implemented which pass the features prop to the WithRegistrySetup component. However, the component doesn't have this prop and it's ignored.

The stories are working as expected because the features prop is provided via parameters.

For example:

site-kit-wp/assets/js/modules/ads/components/settings/SettingsEdit.stories.js

Lines 99 to 123 in e112780

	PaxConnected.parameters = {
	features: [ 'adsPax' ],
	};
	PaxConnected.decorators = [
	( Story, { parameters } ) => {
	const setupRegistry = ( registry ) => {
	// Unset the value set in the prrevious scenario.
	registry.dispatch( MODULES_ADS ).setConversionID( null );
	registry.dispatch( MODULES_ADS ).receiveGetSettings( {
	paxConversionID: 'AW-54321',
	extCustomerID: 'C-872756827HGFSD',
	} );
	};
	return (
	<WithRegistrySetup
	func={ setupRegistry }
	features={ parameters.features || [] }
	>
	<Story />
	</WithRegistrySetup>
	);
	},
	];

Note how WithRegistrySetup doesn't have the features prop:

site-kit-wp/tests/js/WithRegistrySetup.js

Line 35 in e112780

function WithRegistrySetup( { func, children } ) {

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

• Stories using WithRegistrySetup should not attempt to pass the features prop to it.

Implementation Brief

• Update the following stories, removing the features prop from the use of WithRegistrySetup:

  • site-kit-wp/assets/js/components/conversion-tracking/ConversionTrackingToggle.stories.js

    Line 62 in 798b43c

    features={ parameters.features || [] }

  • site-kit-wp/assets/js/components/conversion-tracking/ConversionTrackingToggle.stories.js

    Line 96 in 798b43c

    features={ parameters.features || [] }

  • site-kit-wp/assets/js/modules/ads/components/settings/SettingsEdit.stories.js

    Line 117 in 798b43c

    features={ parameters.features || [] }

  • site-kit-wp/assets/js/modules/ads/components/settings/SettingsEdit.stories.js

    Line 147 in 798b43c

    features={ parameters.features || [] }

  • site-kit-wp/assets/js/modules/ads/components/settings/SettingsEdit.stories.js

    Line 177 in 798b43c

    features={ parameters.features || [] }

  • site-kit-wp/assets/js/modules/analytics-4/components/settings/SettingsForm.stories.js

    Line 240 in 798b43c

    features={ parameters.features || [] }

• Remove any unused imports caused by these changes.

Test Coverage

• Confirm VRTs still pass and components which require feature flags still render in storybook. Feature flags should be passed on the main story definition.

QA Brief

Refer the storybook and ensure that following stories are rendering properly and as expected.

• Analytics-4 SettingsEdit
• Ads SettingsEdit
• ConversionTrackingToggle

Changelog entry

• Remove the use of the non-existent features prop in stories using the WithRegistrySetup component.

[eugene-manuilov]

IB ✔️

[hussain-t]

Hi @ankitrox, could you please provide the links to the stories to be verified in the QAB? Thanks!

[ankitrox]

Thanks @hussain-t

I have added links to those stories.

[mohitwp]

QA Update ✅

• Tested on dev environment.

• Tested below Stories -

• Analytics-4 SettingsEdit

• Ads SettingsEdit

• ConversionTrackingToggle

• Verified that above stories are rendering properly and as expected.