Fix conditions for showing the publication approved overlay notification

[techanvil]

Feature Description

When the onboarding state for the current publication is synced, the publication approved overlay notification should appear, but only when the onboarding state has changed from another non-empty state.

At present the notification will appear even if the publication was already in the onboarding state prior to the sync. See https://github.com/google/site-kit-wp/pull/9017/files#r1693880442.

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

• While viewing the dashboard, when the onboarding state for the current publication is synced, the publication approved overlay notification should appear, but only when the onboarding state has changed from another non-empty state.

Implementation Brief

• In assets/js/modules/reader-revenue-manager/datastore/publications.js, update following condition

site-kit-wp/assets/js/modules/reader-revenue-manager/datastore/publications.js

Lines 131 to 134 in e72c216

	if (
	onboardingState ===
	PUBLICATION_ONBOARDING_STATES.ONBOARDING_COMPLETE
	) {

add following check along with existing one

onboardingState !== currentOnboardingState

Test coverage

• Add the test coverage for status transition change.

QA Brief

• Set up Site Kit with a Google account that has one or more publications in the publisher center.
• Using the tester plugin, enable the rrmModule feature flag, and change the "_
  Force Reader Revenue Manager publication onboarding state_" setting to something other than ONBOARDING_COMPLETE.
• Set up the RRM module.
• Go to the Site Kit dashboard and verify that the publication approved overlay notification is not shown.
• Go to the tester plugin and change the RRM setting to ONBOARDING_COMPLETE.
• Go back to the dashboard and in the browser console, run the following script:

googlesitekit.data.dispatch( 'modules/reader-revenue-manager' ).syncPublicationOnboardingState()

• Verify that after a few seconds, the publication approved overlay notification is displayed.
• Refresh the page and run the above script again. Verify that the overlay notification is no longer displayed.
• Besides the above, also perform a smoke test using the QAB for Implement RRM syncPublicationOnboardingState() action #8796 and Implement RRM maybeSyncPublicationOnboardingState() action #8797, as this includes a few improvements regarding those areas.

Changelog entry

• N/A

[nfmohit]

AC ✅

Thank you @techanvil !

[nfmohit]

The IB looks good to me, @ankitrox. Would you agree that it would be wise to increase the estimate to a 7 at least, considering there's test coverage involved? If so, could you please update the estimate? Thank you!

[ankitrox]

Hi @nfmohit

Thanks for flagging this. I had been conservative, but this exceeds the estimated time considering the fact that we may have to adjust test cases and may encounter some unforeseen scenarios.

I have updated estimate to 7 as it sounds correct.

Thanks again.

[nfmohit]

Thank you @ankitrox !

IB ✅

[wpdarren]

QA Update: ✅

Verified:

Onboarding state setting to something other than ONBOARDING_COMPLETE.

• The publication approved overlay notification is not shown.

Onboarding state setting to ONBOARDING_COMPLETE.

• After a few seconds, the publication approved overlay notification is displayed.

Refreshing the page and running the above script again.

• The overlay notification is no longer displayed.

Besides the above, I also performed a smoke test using the QAB for #8796 and #8797. I will be creating a more thorough smoke test of the entire RRM functionality as approaching the completion of the bug bash instructions.