-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor RRMSetupSuccessSubtleNotification
to use the new Notifications datastore
#8981
Open
3 tasks done
Labels
Comments
jimmymadon
added
Type: Enhancement
Improvement of an existing feature
Team S
Issues for Squad 1
labels
Jul 8, 2024
tofumatt
changed the title
Refactor the SetupSuccessSubtleNotification to use the new Notifications datastore
Refactor Jul 23, 2024
SetupSuccessSubtleNotification
to use the new Notifications datastore
jimmymadon
changed the title
Refactor
Refactor Aug 12, 2024
SetupSuccessSubtleNotification
to use the new Notifications datastoreRRMSetupSuccessSubtleNotification
to use the new Notifications datastore
AC ✔️ |
IB ✔️ |
19 tasks
@jimmymadon I was thinking about the first option as well. I think it's good idea to keep the CTA because if the user didn't complete customization or lost the page, it will be easier for him to re-visit the link and dismiss it at his convinience. I would replace the "Maybe later" with "got it", this is what we're using in otehr features. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature Description
This is the first issue that refactors the newly implement "subtle notifications" in the plugin as part of Phase 1 of the Banner Notifications Refactoring epic. It should refactor the
RRMSetupSuccessSubtleNotification
so that it uses the new datastore infrastructure to register and queue the notification. It should also incorporate the newly introducedSubtleNotification
component as a new "layout"Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
RRMSetupSuccessSubtleNotification
component should be refactored so that it is registered and rendered (queued) using the newcore/notifications
datastore.<SubtleNotifications>
) but only via the genericgetQueuedNotifications
selector.SubtleNotification
component and refactor this reusable component as a new "layout" within the new notifications framework.Implementation Brief
assets/js/modules/reader-revenue-manager/components/dashboard/RRMSetupSuccessSubtleNotification.js
assets/js/components/notifications/GatheringDataNotification.js
for the exampleSubtleNotification
componentid
andNotification
Notification
component passed as the propSubtleNotification
to create a new layoutassets/js/googlesitekit/notifications/components/layout/SubtleNotification.js
assets/js/googlesitekit/notifications/register-defaults.js
checkRequirements
transfer the existing checks fromassets/js/components/notifications/SubtleNotifications.js
andRRMSetupSuccessSubtleNotification
component itself10
from the last added notification (not including error ones, which start from150
).NOTIFICATION_AREAS.BANNERS_BELOW_NAV
forareaSlug
RRMSetupSuccessSubtleNotification
from theassets/js/components/notifications/SubtleNotifications.js
Test Coverage
assets/js/modules/reader-revenue-manager/components/dashboard/RRMSetupSuccessSubtleNotification.stories.js
QA Brief
/wp-admin/admin.php?page=googlesitekit-dashboard¬ification=authentication_success&slug=reader-revenue-manager
Changelog entry
The text was updated successfully, but these errors were encountered: