-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement RRM getServiceURL()
selector
#8848
Comments
Hi @techanvil, just to confirm, shouldn't this be |
Thanks @nfmohit, apologies for the copy/paste fail! This is now fixed, cheers. |
Brilliant, thanks @techanvil! IB ✅ |
QA Update
|
Hi @kelvinballoo , Thank you for testing this issue.
the publication ID query parameter is added by publisher centre automatically and we do not have the control over it. As you demonstrated in your video, even if we simply visit https://publishercenter.google.com/, that query parameter is getting appended in the URL.
This is fine as the |
QA Update ✅Thanks for the update @ankitrox
Moving this ticket to approval. |
Feature Description
The
getServiceURL()
selector should be implemented for the Reader Revenue Manager module that should return a prepared link to the Reader Revenue Manager platform that meets this criteria.Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
getServiceURL()
selector should be added to the Reader Revenue Manager module data store.https://publishercenter.google.com/
.https://publishercenter.google.com/reader-revenue-manager?publication=PUBLICATION_ID
.utm_source=sitekit
.Implementation Brief
assets/js/modules/reader-revenue-manager/datastore/service.js
.selectors
object, which in turn contains thegetServiceURL()
selector.getServiceURL()
should accept an optionalpublicationId
parameter and implement the logic as defined in the AC to determine the link.getAccountChooserURL()
to wrap the link with the Google account chooser URL.getServiceURL()
implementation for some pointers.Test Coverage
QA Brief
You must get the URL like following
Notice that email will be replaced with your account email.
Clicking on the above link should take you to the publisher center, but page will open in publisher center only if the publication ID is valid (in this case
ABCDEFGH
which is invalid). You can create a publication in https://publishercenter.google.com/ to get the publication ID.Again, in the browser console, run the following script:
Changelog entry
The text was updated successfully, but these errors were encountered: