Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate updating major version of React via @wordpress/data. #6357

Open
techanvil opened this issue Dec 22, 2022 · 3 comments
Open

Investigate updating major version of React via @wordpress/data. #6357

techanvil opened this issue Dec 22, 2022 · 3 comments
Labels
Next Up Issues to prioritize for definition P1 Medium priority Type: Infrastructure Engineering infrastructure & tooling

Comments

@techanvil
Copy link
Collaborator

techanvil commented Dec 22, 2022

Feature Description

Following on from the update to @wordpress/data 4.27.3 in #6356, which is the latest version of @wordpress/data that (via @wordpress/element) supports React 16, we should move on to update the major version of @wordpress/data, and consequently the major versions of @wordpress/element and thus React.

This issue is for an investigation into which specific version of @wordpress/data we can update to, aiming to ensure the upgrade is manageable and avoiding introducing too many breaking changes at once.

The most recent version of @wordpress/data at the time of writing is 8.0.0, which depends on @wordpress/element 5.0.0 and therefore React 18.2.0. This is obviously a bit of a leap from current versions and it's more likely that a manageable approach would be to first update to a specific @wordpress/data@5 version.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • The next @wordpress/data version to update to should be determined. If during the investigation it is found that the update is straightforward it can be done as part of this issue. If not (eg. if the update involves significant engineering effort), a follow-up issue should be created for the update itself.
  • Assuming we don't update to the latest @wordpress/data, a followup issue, similar to this one, should be created for determining a subsequent upgrade, with a long term view to bringing us as up-to-date as possible.

Implementation Brief

Test Coverage

QA Brief

Changelog entry

@techanvil techanvil added P1 Medium priority Type: Infrastructure Engineering infrastructure & tooling labels Dec 22, 2022
@tofumatt tofumatt self-assigned this Jan 4, 2023
@tofumatt
Copy link
Collaborator

tofumatt commented Jan 4, 2023

ACs are largely good but I wanted to note that if the upgrades are straightforward (might be found during the IB process/engineering exploration this issue will be used for), it would make sense to do the upgrade in-place.

But I get this issue is largely about exploration. Moving to IB, though really the IB is more/less the ACs I think 🤔

@tofumatt tofumatt removed their assignment Jan 4, 2023
@kuasha420 kuasha420 self-assigned this Jan 23, 2023
@kuasha420
Copy link
Contributor

Initial investigation

Although #6356 is EB which blocks this one, I had taken some time to look at this from a high level. After examining the source code and changelogs, I think we can realistically target v6.x of the @wordpress/data package where it adds support for React 17.

v5 doesn't add much that we'll need to use (maybe {start|finish}Resolutions would be nice to have). This is marked as major because it drops support for IE11 but from my understanding that is not relevant to us.

I'll pick it up for further exploration once the blocking issue has been worked on and merged.

@kuasha420
Copy link
Contributor

Unassigning myself from this one since #6356 has gone back to IB due to unforeseen issues which blocks this one. Cheers cc @bethanylang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Next Up Issues to prioritize for definition P1 Medium priority Type: Infrastructure Engineering infrastructure & tooling
Projects
None yet
Development

No branches or pull requests

4 participants