Skip to content

Commit c32994f

Browse files
authored
Merge pull request #9928 from google/issue/9816-enable-conversion-event-support-in-pax
Issue / 9816 Enable Conversion Event Support in PAX
2 parents f93a032 + 7305b8b commit c32994f

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

assets/js/modules/ads/pax/services.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -167,8 +167,7 @@ export function createPaxServices( registry, options = {} ) {
167167
getSupportedConversionTrackingTypes: async () => {
168168
return {
169169
conversionTrackingTypes: [
170-
// @TODO: Include TYPE_CONVERSION_EVENT in a future update.
171-
// 'TYPE_CONVERSION_EVENT',
170+
'TYPE_CONVERSION_EVENT',
172171
'TYPE_PAGE_VIEW',
173172
],
174173
};

assets/js/modules/ads/pax/services.test.js

+4-1
Original file line numberDiff line numberDiff line change
@@ -301,7 +301,10 @@ describe( 'PAX partner services', () => {
301301
);
302302

303303
expect( supportedTypes ).toMatchObject( {
304-
conversionTrackingTypes: [ 'TYPE_PAGE_VIEW' ],
304+
conversionTrackingTypes: [
305+
'TYPE_CONVERSION_EVENT',
306+
'TYPE_PAGE_VIEW',
307+
],
305308
} );
306309
} );
307310
} );

0 commit comments

Comments
 (0)