Remove testing for Python 3.4 (#388)

* Removes testing from CI for Python 3.4
* Adds lint disabling for new linter checks that have been added.

Author: dbieber

.github/scripts/build.sh

@@ -39,6 +39,6 @@ if [[ ${PYTHON_VERSION} == 2.7 ]]; then
     fire/inspectutils_test.py \
     fire/test_components_py3.py;
 elif [[ ${PYTHON_VERSION} == 3.7 ]]; then
-  pytype;
+  pytype -x fire/test_components_py3.py;
 fi
 

.github/workflows/build.yml

@@ -7,7 +7,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        python-version: [2.7, 3.4, 3.5, 3.7, 3.8, 3.9]
+        python-version: [2.7, 3.5, 3.7, 3.8, 3.9]
 
     steps:
      # Checkout the repo.

fire/__main__.py

@@ -80,7 +80,7 @@ def import_from_file_path(path):
     spec.loader.exec_module(module)  # pytype: disable=attribute-error
 
   else:
-    import imp  # pylint: disable=g-import-not-at-top,import-outside-toplevel
+    import imp  # pylint: disable=g-import-not-at-top,import-outside-toplevel,deprecated-module
     module = imp.load_source(module_name, path)
 
   return module, module_name

fire/custom_descriptions.py

@@ -137,15 +137,15 @@ def GetStringTypeDescription(obj, available_space, line_length):
 
 def GetSummary(obj, available_space, line_length):
   obj_type_name = type(obj).__name__
-  if obj_type_name in CUSTOM_DESC_SUM_FN_DICT.keys():
+  if obj_type_name in CUSTOM_DESC_SUM_FN_DICT:
     return CUSTOM_DESC_SUM_FN_DICT.get(obj_type_name)[0](obj, available_space,
                                                          line_length)
   return None
 
 
 def GetDescription(obj, available_space, line_length):
   obj_type_name = type(obj).__name__
-  if obj_type_name in CUSTOM_DESC_SUM_FN_DICT.keys():
+  if obj_type_name in CUSTOM_DESC_SUM_FN_DICT:
     return CUSTOM_DESC_SUM_FN_DICT.get(obj_type_name)[1](obj, available_space,
                                                          line_length)
   return None

fire/main_test.py

@@ -44,11 +44,11 @@ class MainModuleFileTest(testutils.BaseTestCase):
 
   def setUp(self):
     super(MainModuleFileTest, self).setUp()
-    self.file = tempfile.NamedTemporaryFile(suffix='.py')
+    self.file = tempfile.NamedTemporaryFile(suffix='.py')  # pylint: disable=consider-using-with
     self.file.write(b'class Foo:\n  def double(self, n):\n    return 2 * n\n')
     self.file.flush()
 
-    self.file2 = tempfile.NamedTemporaryFile()
+    self.file2 = tempfile.NamedTemporaryFile()  # pylint: disable=consider-using-with
 
   def testFileNameFire(self):
     # Confirm that the file is correctly imported and doubles the number.

pylintrc

@@ -32,7 +32,7 @@ enable=indexing-exception,old-raise-syntax
 # Disable the message, report, category or checker with the given id(s). You
 # can either give multiple identifier separated by comma (,) or put this option
 # multiple time.
-disable=design,similarities,no-self-use,attribute-defined-outside-init,locally-disabled,star-args,pointless-except,bad-option-value,global-statement,fixme,suppressed-message,useless-suppression,locally-enabled,file-ignored,wrong-import-order,useless-object-inheritance,no-else-return,super-with-arguments,raise-missing-from
+disable=design,similarities,no-self-use,attribute-defined-outside-init,locally-disabled,star-args,pointless-except,bad-option-value,global-statement,fixme,suppressed-message,useless-suppression,locally-enabled,file-ignored,wrong-import-order,useless-object-inheritance,no-else-return,super-with-arguments,raise-missing-from,consider-using-f-string,unspecified-encoding
 
 
 [REPORTS]

setup.py

@@ -66,7 +66,6 @@
         'Programming Language :: Python :: 2',
         'Programming Language :: Python :: 2.7',
         'Programming Language :: Python :: 3',
-        'Programming Language :: Python :: 3.4',
         'Programming Language :: Python :: 3.5',
         'Programming Language :: Python :: 3.6',
         'Programming Language :: Python :: 3.7',