You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fix should be as easy as renaming the variable to $_result. We can't rename it to anything that could be a Dart identifier for a proto field (e.g. result) as that will cause shadowing in the method body.
We should also update protobuf and protoc_pluginlints deps to 2.0. If we do that then we will start checking generated files for lints-2.0 as we run dart analyze after generating protos in CI.
The text was updated successfully, but these errors were encountered:
lints-2.0.0 enables a few new lints, and currently code we generate does not follow
no_leading_underscores_for_local_identifiers
as we generate_result
in message factory methods.Fix should be as easy as renaming the variable to
$_result
. We can't rename it to anything that could be a Dart identifier for a proto field (e.g.result
) as that will cause shadowing in the method body.We should also update
protobuf
andprotoc_plugin
lints
deps to 2.0. If we do that then we will start checking generated files for lints-2.0 as we rundart analyze
after generating protos in CI.The text was updated successfully, but these errors were encountered: