Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin should support system search path #700

Closed
YifeiZhuang opened this issue May 9, 2023 · 1 comment · Fixed by #702
Closed

plugin should support system search path #700

YifeiZhuang opened this issue May 9, 2023 · 1 comment · Fixed by #702

Comments

@YifeiZhuang
Copy link
Collaborator

This doc is not clear

// If you don't locate it, protoc will try to use "protoc-gen-grpc" from

This configuration generates command --plugin=protoc-gen-grpc=protoc-gen-grpc, and only works when protoc-gen-grpc exists in the current build directory. It does not search the system path.

plugins {
    grpc {

    }
      generateProtoTasks {
        all()*.plugins { grpc {} }
    }
  }

if the entire plugins configuration is omitted, then it generates command without --plugin flag, which searches for system path. Maybe make the above configuration searching for system path is better behavior, because it allows using system path and configuration each plugin separately.

@YifeiZhuang
Copy link
Collaborator Author

related to #699

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant