Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JSON file access by karma/jasmine tests #324

Open
drinckes opened this issue May 3, 2019 · 2 comments
Open

Update JSON file access by karma/jasmine tests #324

drinckes opened this issue May 3, 2019 · 2 comments

Comments

@drinckes
Copy link
Contributor

drinckes commented May 3, 2019

Existing node JS tests (in js/test) use a combination of gulp and phantomjs to run.

phantomjs is now unsupported (and seems to be a pain to get working locally) so it would be good to refactor the tests to use karma/jasmine.

I've had a quick go at this but got stuck trying to get the test functions to access the CSV files. (If we have to we could convert them to JSON as part of the test script.)

@drinckes
Copy link
Contributor Author

drinckes commented May 3, 2019

This is mostly done with #305. But this uses karma-jasmine-jquery which hasn't been updated for a long time, and has a lot of issues with pulling in old, obsolete dependencies.

So it would be good if someone with a bit more time and karma/jasmine experience could find a more up-to-date way to access JSON files from within tests.

@drinckes drinckes changed the title Change node JS tests to karma/jasmine Update JSON file access by karma/jasmine tests May 3, 2019
@fulldecent
Copy link
Contributor

Recommended tag: implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants