Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support python 3.12 and misc #205

Open
wants to merge 53 commits into
base: main
Choose a base branch
from
Open

Support python 3.12 and misc #205

wants to merge 53 commits into from

Conversation

romanngg
Copy link
Contributor

@romanngg romanngg commented Sep 3, 2024

Maintenance:

  • Support python 3.12 and drop 3.10
  • Remove obsolete type annotations
  • Improve type annotations and enable pytype in more places
  • Fix some deprecated calls
  • Formatting
  • Upgrade dependencies

Resolves #202

@romanngg
Update setup.py
dfd7c8f
@romanngg
Update setup.py
c460bed
@romanngg
Update linux.yml
5434520
@romanngg
Update macos.yml
93100cc
@romanngg
Update setup.py
ae1bede
@romanngg
Update setup.py
bb18562
@romanngg
Update setup.py
266b8ec
@romanngg
Update setup.py
821960f
@romanngg
Update setup.py
e824bf9
@romanngg
Update setup.py
a4130ac
@romanngg
Update empirical.py
433f82e
@romanngg
Update empirical_tf_test.py
aff65c1
@romanngg
Update setup.py
f928978
@romanngg
Update setup.py
fb29308
@romanngg
Update empirical_tf_test.py
a6b2cd9
@romanngg
Update empirical_tf_test.py
387d32f
@romanngg
Update empirical_ntk_tf_test.py
f31a2d9
@romanngg
Update empirical_ntk_tf_test.py
3cc684d
@romanngg
Update setup.py
2256a35
@romanngg
Update setup.py
83bf6f0
@romanngg
Update linux.yml
04b03b5
@romanngg
Update macos.yml
8028008
@romanngg
Update setup.py
46f03fa
@romanngg
Update linux.yml
73fd32a
@romanngg
Update macos.yml
dd709d8
@romanngg
Update pytype.yml
e4901cf
@romanngg
Update sketching.yml
abee391
@romanngg
Update predict.py
63e257c
@romanngg
Update setup.py
c365aeb
@romanngg
Update setup.py
d4b1df2
@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 91.56627% with 14 lines in your changes missing coverage. Please review.

Project coverage is 85.05%. Comparing base (e91c80e) to head (a017fab).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
neural_tangents/_src/utils/rules.py 73.91% 6 Missing ⚠️
neural_tangents/_src/empirical.py 94.44% 2 Missing ⚠️
neural_tangents/_src/stax/linear.py 80.00% 2 Missing ⚠️
neural_tangents/_src/utils/typing.py 84.61% 2 Missing ⚠️
neural_tangents/_src/batching.py 88.88% 1 Missing ⚠️
...al_tangents/experimental/empirical_tf/empirical.py 80.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #205      +/-   ##
==========================================
- Coverage   85.12%   85.05%   -0.07%     
==========================================
  Files          19       19              
  Lines        5175     5151      -24     
==========================================
- Hits         4405     4381      -24     
  Misses        770      770

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@romanngg romanngg marked this pull request as ready for review September 3, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SiuMath SiuMath SiuMath approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tag a release
3 participants
@romanngg @codecov-commenter @SiuMath