Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate RPC names aren't detected, but stop the RPC server from booting up. #133

Open
EvanWittGoogle opened this issue Sep 26, 2023 · 2 comments

Comments

@EvanWittGoogle
Copy link

I recently had to manually debug a case where I'd added a duplicate RPC name. The error I got when doing this is a generic server protocol error, as follows:

mobly.snippet.errors.ServerStartProtocolError: <AndroidDevice|8f152933> INSTRUMENTATION_RESULT: shortMsg=Process crashed.

As my team is planning to add many new RPCs to our local copy of this snippet, it might prevent alot of headache if this particular error could be detected or flagged with a clearer error message, identifying (or at least mentioning) the duplicate RPC name. Is this possible to implement?

@xpconanfan
Copy link
Collaborator

Thanks for reporting this.
Seems reasonable.
Could you file an internal FR to track this as well?

@EvanWittGoogle
Copy link
Author

Filed the internal FR. This is my first time working with gitHub in this way (i.e., in collaboration as an FTE), so let me know if there's a part of the process I'm missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants