Fix some typing issue in generate_default_trace #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boomanaiden154
force-pushed
the
fix-typing-generate-default-trace
branch
from
a1d0e7e to
0f0583c
Compare
This patch removes an outdated comment (related to importing typing annotations and then leaving everything in strings to a lack of support from tooling at the time), removes a pylint disabled error as it no longer applies, replace one string type with the actual type as it should work now, and removes one no longer used type definition.
boomanaiden154
force-pushed
the
fix-typing-generate-default-trace
branch
from
0f0583c to
3faa47b
Compare
mtrofin
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes an outdated comment (related to importing typing annotations and then leaving everything in strings to a lack of support from tooling at the time), removes a pylint disabled error as it no longer applies, and removes one no longer used type definition.