Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MESOP_CONCURRENT_UPDATES_ENABLED - concurrent streaming requests has odd behavior maybe #981

Open
richard-to opened this issue Sep 21, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@richard-to
Copy link
Collaborator

Need to look into this one more to determine if this is a big issue or not. Could be minor. I'm also not sure the reason for the issue yet.

I was testing out the animation demo. Basically I clicked "Transform Color" followed by "Fade In / Fade Out". I also tested out the reverse.

What happens in this scenario is that the second animation that is clicked will not fully finish. The final rendering will be some intermediate state.

@richard-to richard-to added the bug Something isn't working label Sep 21, 2024
@wwwillchen
Copy link
Collaborator

Good catch - it looks like what's happening (when I inspect the network tab) is that when there's two concurrent event streams, whichever finishes first, will also close the second one, which makes sense because:

this.eventSource.close();

I'm not sure what's the right way of solving this, we could have a map of eventSource (instead of having a single one, it's actually kind of interesting how the concurrent updates even works with the single eventSource instance) or we can have some kind of counter to keep track of the pending requests and still use a single eventSoruce.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants