New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider making dataclasses in the API keyword-only #76

Closed

wwwillchen opened this issue Mar 19, 2024 · 1 comment · Fixed by #80

Collaborator

wwwillchen commented Mar 19, 2024

https://docs.python.org/3.10/library/dataclasses.html#dataclasses.KW_ONLY
This would be a breaking change though

wwwillchen mentioned this issue

Make all (API-exposed) dataclass kw-only #80

Merged

Collaborator Author

wwwillchen commented Mar 21, 2024

I think it's good to do this now while usage of Mesop is relatively limited. I think the two main reasons for doing keyword-only is:

it makes it easier to evolve the API (otherwise, we'll need to be careful of only appending new attributes to the bottom of the dataclass definition)
it encourages, IMO, cleaner code at the call-sites as it's more explicit than passing by position

wwwillchen closed this as completed in #80

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment