Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Departure board SVG has useless stray points #1828

Open
davwheat opened this issue Nov 1, 2024 · 4 comments
Open

Departure board SVG has useless stray points #1828

davwheat opened this issue Nov 1, 2024 · 4 comments
Assignees
Labels

Comments

@davwheat
Copy link

davwheat commented Nov 1, 2024

See the blue points in the image below.

Image

Image

This results in some rendering artifacts in Firefox

Image

@tphinney
Copy link
Collaborator

tphinney commented Nov 7, 2024

Ah. OK, that is a bug. We should be hiding the points that need to expand into the Filled shape in the existing contours, precisely because Apple will render a zero-thickness line like what you see there. I can see in my icon source that we failed to do that.

Would I be right to guess you are viewing this on macOS or iOS? Not Windows or Linux.

At 100% fill we have a whole different workaround just to avoid this. We are super familiar with the issue and just in this case forgot that we have to avoid it in a different way at zero Fill. Oops. Rats!

Sorry about that. It will likely be at least a week or two before a fix percolates out to the repo and to the live font being served.

@tphinney tphinney self-assigned this Nov 7, 2024
@tphinney tphinney added the bug label Nov 7, 2024
@davwheat
Copy link
Author

davwheat commented Nov 7, 2024

Ah. OK, that is a bug. We should be hiding the points that need to expand into the Filled shape in the existing contours, precisely because Apple will render a zero-thickness line like what you see there. I can see in my icon source that we failed to do that.

Would I be right to guess you are viewing this on macOS or iOS? Not Windows or Linux.

When I first saw it (which was where I took the browser screenshot) was on the MDI Google Font page in Firefox on Windows.

From later testing (now) it seems to not affect the SVG on any of the browsers or devices I've tested on (I only run Linux and Windows), but does affect Firefox and Chrome's (to a lesser extent) font rendering engines. Whether that's expected from the font I don't know! :)

Firefox Windows:
Image

Chrome Windows:
Image

It's not an issue or blocker for me right now anyway -- I just deleted the points and continued with my day importing it into Android Studio. Thanks for following up so quickly!

@tphinney
Copy link
Collaborator

tphinney commented Nov 7, 2024

Thanks! We will take care of it. May take a few weeks to percolate out to being public, though.

@tphinney
Copy link
Collaborator

tphinney commented Nov 9, 2024

Got the fix into the build I checked in half an hour ago, v2.799
If all goes well, it will probably be live some time this month.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants