Skip to content
This repository has been archived by the owner on Jun 19, 2022. It is now read-only.

Rename serviceAccount in IdentitySpec #723

Closed
grac3gao-zz opened this issue Mar 27, 2020 · 0 comments · Fixed by #736
Closed

Rename serviceAccount in IdentitySpec #723

grac3gao-zz opened this issue Mar 27, 2020 · 0 comments · Fixed by #736
Labels
area/api APIs area/security kind/bug Something isn't working priority/1 Blocks current release defined by release/* label or blocks current milestone release/1

Comments

@grac3gao-zz
Copy link
Contributor

Describe the bug
For workload identity we added a spec.serviceAccount field to all constructs. That refers to a google service account. Rename it to a longer, unambiguous name GoogleServiceAccount
#614 (comment)

Expected behavior
Rename serviceAccount
@grac3gao-zz grac3gao-zz added the kind/bug Something isn't working label Mar 27, 2020
@grac3gao-zz grac3gao-zz mentioned this issue Mar 27, 2020
Closed
@grantr grantr added area/security area/api APIs priority/1 Blocks current release defined by release/* label or blocks current milestone release/1 labels Mar 30, 2020
@grac3gao-zz grac3gao-zz mentioned this issue Mar 30, 2020
Merged
@grac3gao-zz grac3gao-zz mentioned this issue Apr 1, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area/api APIs area/security kind/bug Something isn't working priority/1 Blocks current release defined by release/* label or blocks current milestone release/1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename ServiceAccount in IdentitySpec grac3gao-zz/knative-gcp
2 participants
@grantr @grac3gao-zz