Skip to content
This repository has been archived by the owner on Jun 19, 2022. It is now read-only.

Data residency configmap is not validated by webhook #1741

Closed
grantr opened this issue Sep 18, 2020 · 0 comments · Fixed by #1747
Closed

Data residency configmap is not validated by webhook #1741

grantr opened this issue Sep 18, 2020 · 0 comments · Fixed by #1747
Assignees
@zhongduo
Labels
area/broker area/sources kind/bug Something isn't working priority/1 Blocks current release defined by release/* label or blocks current milestone release/2
Milestone
Backlog

Comments

@grantr
Copy link
Contributor

grantr commented Sep 18, 2020

Describe the bug
Followup from #1681 (comment).

Expected behavior
Invalid keys in the config-data-residency configmap cause a webhook error.

/assign @zhongduo
@grantr grantr added the kind/bug Something isn't working label Sep 18, 2020
@zhongduo zhongduo mentioned this issue Sep 21, 2020
Merged
@grantr grantr added area/broker area/sources priority/1 Blocks current release defined by release/* label or blocks current milestone release/2 labels Sep 22, 2020
@grantr grantr added this to the Backlog milestone Sep 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@zhongduo zhongduo

Labels
area/broker area/sources kind/bug Something isn't working priority/1 Blocks current release defined by release/* label or blocks current milestone release/2
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Add data residency validation to webhook zhongduo/knative-gcp
2 participants
@grantr @zhongduo