Skip to content
This repository has been archived by the owner on Jun 19, 2022. It is now read-only.

Allow the controller to inject istio sidecar proxy. #1732

Closed
upodroid opened this issue Sep 17, 2020 · 1 comment · Fixed by #1736
Closed

Allow the controller to inject istio sidecar proxy. #1732

upodroid opened this issue Sep 17, 2020 · 1 comment · Fixed by #1736
Labels
area/security kind/feature-request New feature or request

Comments

@upodroid
Copy link

Problem
I need to have istio sidecar injected in to every pod but the Controller sets sidecar.istio.io/inject to false.

Persona:
Which persona is this feature for? All

Exit Criteria
Istio Injection is set to true.

Time Estimate (optional):
How many developer-days do you think this may take to resolve? Half a day?

Additional context (optional)
This PR #1476 disabled sidecar injection.
@upodroid upodroid added the kind/feature-request New feature or request label Sep 17, 2020
@upodroid
Copy link
Author

@yolocs ^

@yolocs yolocs mentioned this issue Sep 17, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area/security kind/feature-request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow istio sidecar injection for all broker components yolocs/knative-gcp
2 participants
@danyinggu @upodroid