Skip to content
This repository has been archived by the owner on Jun 19, 2022. It is now read-only.

Remove old GCP resources, receive adapters, and publishers #1217

Closed
nachocano opened this issue Jun 4, 2020 · 1 comment · Fixed by #1380
Closed

Remove old GCP resources, receive adapters, and publishers #1217

nachocano opened this issue Jun 4, 2020 · 1 comment · Fixed by #1380
Assignees
@nachocano
Labels
area/sources kind/bug Something isn't working priority/1 Blocks current release defined by release/* label or blocks current milestone
Milestone
v0.16.0-M3

Comments

@nachocano
Copy link
Member

nachocano commented Jun 4, 2020 •
edited
Loading

Describe the bug
In #1207 we renamed all GCP resources created by sources, as well as the receive adapters. We should clean up those old resources in code so that users can have a smooth upgrade experience.
Also #1226 avoids creating unnecessary publishers for sources. We should delete the already created ones.
We agreed on doing this in a follow up as it will get nasty and will take sometime.
This is a 0.16 blocker.

Expected behavior
No GCP resources are leaked when upgrading to 0.16.
@nachocano nachocano added kind/bug Something isn't working priority/1 Blocks current release defined by release/* label or blocks current milestone labels Jun 4, 2020
@nachocano
Copy link
Member Author

fyi @Harwayne

@nachocano nachocano mentioned this issue Jun 4, 2020
Merged
@nachocano nachocano changed the title Remove old GCP resources and receive adapters Remove old GCP resources, receive adapters, and publishers Jun 5, 2020
@grantr grantr modified the milestones: v0.16.0-M2, v0.16.0-M3 Jun 9, 2020
@nachocano nachocano self-assigned this Jun 25, 2020
@nachocano nachocano mentioned this issue Jul 6, 2020
Merged
@Harwayne Harwayne mentioned this issue Jul 7, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@nachocano nachocano

Labels
area/sources kind/bug Something isn't working priority/1 Blocks current release defined by release/* label or blocks current milestone
Projects
None yet
Milestone
v0.16.0-M3
Development

Successfully merging a pull request may close this issue.

Removing/Updating old publisher, ra, and pubsub resources nachocano/knative-gcp
2 participants
@grantr @nachocano