Skip to content
This repository has been archived by the owner on Jun 19, 2022. It is now read-only.

Remove spec.googleServiceAccount in v1alpha1 #1205

Closed
grac3gao-zz opened this issue Jun 3, 2020 · 0 comments · Fixed by #1249
Closed

Remove spec.googleServiceAccount in v1alpha1 #1205

grac3gao-zz opened this issue Jun 3, 2020 · 0 comments · Fixed by #1249
Assignees
@grac3gao-zz
Labels
area/api APIs kind/feature-request New feature or request

Comments

@grac3gao-zz
Copy link
Contributor

Problem
spec.googleServiceAccount in v1alpha1 is deprecated. We will remove it in 0.16 release.
spec.serviceAccountName replaces it in v1beta1.

Persona:
Which persona is this feature for?

Exit Criteria
Removing spec.googleServiceAccount, together, deleting any controller logic related on googleServiceAccount

Time Estimate (optional):
How many developer-days do you think this may take to resolve?

Additional context (optional)
Add any other context about the feature request here.
@grac3gao-zz grac3gao-zz added kind/feature-request New feature or request area/api APIs labels Jun 3, 2020
@grac3gao-zz grac3gao-zz changed the title Removing spec.googleServiceAccount in v1alpha1 Remove spec.googleServiceAccount in v1alpha1 Jun 3, 2020
@grac3gao-zz grac3gao-zz self-assigned this Jun 9, 2020
@grac3gao-zz grac3gao-zz mentioned this issue Jun 9, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@grac3gao-zz grac3gao-zz

Labels
area/api APIs kind/feature-request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove spec.googleServiceAccount in v1alpha1 grac3gao-zz/knative-gcp
1 participant
@grac3gao-zz