Skip to content

Commit bbacfd7

Browse files
committed
Treat TRY/CATCH macros as block start and end
1 parent 8d4e17b commit bbacfd7

File tree

2 files changed

+32
-22
lines changed

2 files changed

+32
-22
lines changed

.clang-format

+2-2
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,8 @@ IndentWrappedFunctionNames: false
5252
JavaScriptQuotes: Leave
5353
JavaScriptWrapImports: true
5454
KeepEmptyLinesAtTheStartOfBlocks: false
55-
MacroBlockBegin: ''
56-
MacroBlockEnd: ''
55+
MacroBlockBegin: '^TRY$'
56+
MacroBlockEnd: '^CATCH$'
5757
MaxEmptyLinesToKeep: 1
5858
NamespaceIndentation: None
5959
PenaltyBreakAssignment: 2

core/libjsonnet.cpp

+30-20
Original file line numberDiff line numberDiff line change
@@ -284,14 +284,16 @@ const char *jsonnet_version(void)
284284

285285
JsonnetVm *jsonnet_make(void)
286286
{
287-
TRY return new JsonnetVm();
287+
TRY
288+
return new JsonnetVm();
288289
CATCH("jsonnet_make")
289290
return nullptr;
290291
}
291292

292293
void jsonnet_destroy(JsonnetVm *vm)
293294
{
294-
TRY delete vm;
295+
TRY
296+
delete vm;
295297
CATCH("jsonnet_destroy")
296298
}
297299

@@ -444,25 +446,27 @@ static char *jsonnet_fmt_snippet_aux(JsonnetVm *vm, const char *filename, const
444446

445447
char *jsonnet_fmt_file(JsonnetVm *vm, const char *filename, int *error)
446448
{
447-
TRY std::ifstream f;
448-
f.open(filename);
449-
if (!f.good()) {
450-
std::stringstream ss;
451-
ss << "Opening input file: " << filename << ": " << strerror(errno);
452-
*error = true;
453-
return from_string(vm, ss.str());
454-
}
455-
std::string input;
456-
input.assign(std::istreambuf_iterator<char>(f), std::istreambuf_iterator<char>());
449+
TRY
450+
std::ifstream f;
451+
f.open(filename);
452+
if (!f.good()) {
453+
std::stringstream ss;
454+
ss << "Opening input file: " << filename << ": " << strerror(errno);
455+
*error = true;
456+
return from_string(vm, ss.str());
457+
}
458+
std::string input;
459+
input.assign(std::istreambuf_iterator<char>(f), std::istreambuf_iterator<char>());
457460

458-
return jsonnet_fmt_snippet_aux(vm, filename, input.c_str(), error);
461+
return jsonnet_fmt_snippet_aux(vm, filename, input.c_str(), error);
459462
CATCH("jsonnet_fmt_file")
460463
return nullptr; // Never happens.
461464
}
462465

463466
char *jsonnet_fmt_snippet(JsonnetVm *vm, const char *filename, const char *snippet, int *error)
464467
{
465-
TRY return jsonnet_fmt_snippet_aux(vm, filename, snippet, error);
468+
TRY
469+
return jsonnet_fmt_snippet_aux(vm, filename, snippet, error);
466470
CATCH("jsonnet_fmt_snippet")
467471
return nullptr; // Never happens.
468472
}
@@ -621,44 +625,50 @@ static char *jsonnet_evaluate_file_aux(JsonnetVm *vm, const char *filename, int
621625

622626
char *jsonnet_evaluate_file(JsonnetVm *vm, const char *filename, int *error)
623627
{
624-
TRY return jsonnet_evaluate_file_aux(vm, filename, error, REGULAR);
628+
TRY
629+
return jsonnet_evaluate_file_aux(vm, filename, error, REGULAR);
625630
CATCH("jsonnet_evaluate_file")
626631
return nullptr; // Never happens.
627632
}
628633

629634
char *jsonnet_evaluate_file_multi(JsonnetVm *vm, const char *filename, int *error)
630635
{
631-
TRY return jsonnet_evaluate_file_aux(vm, filename, error, MULTI);
636+
TRY
637+
return jsonnet_evaluate_file_aux(vm, filename, error, MULTI);
632638
CATCH("jsonnet_evaluate_file_multi")
633639
return nullptr; // Never happens.
634640
}
635641

636642
char *jsonnet_evaluate_file_stream(JsonnetVm *vm, const char *filename, int *error)
637643
{
638-
TRY return jsonnet_evaluate_file_aux(vm, filename, error, STREAM);
644+
TRY
645+
return jsonnet_evaluate_file_aux(vm, filename, error, STREAM);
639646
CATCH("jsonnet_evaluate_file_stream")
640647
return nullptr; // Never happens.
641648
}
642649

643650
char *jsonnet_evaluate_snippet(JsonnetVm *vm, const char *filename, const char *snippet, int *error)
644651
{
645-
TRY return jsonnet_evaluate_snippet_aux(vm, filename, snippet, error, REGULAR);
652+
TRY
653+
return jsonnet_evaluate_snippet_aux(vm, filename, snippet, error, REGULAR);
646654
CATCH("jsonnet_evaluate_snippet")
647655
return nullptr; // Never happens.
648656
}
649657

650658
char *jsonnet_evaluate_snippet_multi(JsonnetVm *vm, const char *filename, const char *snippet,
651659
int *error)
652660
{
653-
TRY return jsonnet_evaluate_snippet_aux(vm, filename, snippet, error, MULTI);
661+
TRY
662+
return jsonnet_evaluate_snippet_aux(vm, filename, snippet, error, MULTI);
654663
CATCH("jsonnet_evaluate_snippet_multi")
655664
return nullptr; // Never happens.
656665
}
657666

658667
char *jsonnet_evaluate_snippet_stream(JsonnetVm *vm, const char *filename, const char *snippet,
659668
int *error)
660669
{
661-
TRY return jsonnet_evaluate_snippet_aux(vm, filename, snippet, error, STREAM);
670+
TRY
671+
return jsonnet_evaluate_snippet_aux(vm, filename, snippet, error, STREAM);
662672
CATCH("jsonnet_evaluate_snippet_stream")
663673
return nullptr; // Never happens.
664674
}

0 commit comments

Comments
 (0)