Initial implementation of jnp.delete #6085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
froystig
approved these changes
Mar 16, 2021
jakevdp
force-pushed
the
delete
branch
2 times, most recently
from
03325fd
to
68a8673
Compare
copybara-service bot
pushed a commit
that referenced
this pull request
Mar 17, 2021
-- dacc28c by George Necula <[email protected]>: [jax2tf] Added instructions for using OSS TensorFlow model server. FUTURE_COPYBARA_INTEGRATE_REVIEW=#6085 from jakevdp:delete 737e479 PiperOrigin-RevId: 363444176
Merged
copybara-service bot
pushed a commit
that referenced
this pull request
Mar 17, 2021
-- dacc28c by George Necula <[email protected]>: [jax2tf] Added instructions for using OSS TensorFlow model server. FUTURE_COPYBARA_INTEGRATE_REVIEW=#6085 from jakevdp:delete 737e479 PiperOrigin-RevId: 363444176
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires the
objargument specifying which indices to delete to be static; in theory it could be dynamic because the output shape can be known at compile time, but I don't know if it's currently possible to express that in terms of JAX primitives (adeleteprimitive might be the answer to that; I'm not sure).