Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lower tan to StableHLO instead of CHLO. #23261

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Lower tan to StableHLO instead of CHLO. #23261

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions jax/_src/lax/lax.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,6 +340,10 @@ def cos(x: ArrayLike) -> Array:
r"""Elementwise cosine: :math:`\mathrm{cos}(x)`."""
return cos_p.bind(x)

def tan(x: ArrayLike) -> Array:
r"""Elementwise tangent: :math:`\mathrm{tan}(x)`."""
return tan_p.bind(x)

def atan2(x: ArrayLike, y: ArrayLike) -> Array:
r"""Elementwise arc tangent of two variables:
:math:`\mathrm{atan}({x \over y})`."""
Expand Down Expand Up @@ -1549,10 +1553,6 @@ def f_wrapped(x):

return f_wrapped

def tan(x: ArrayLike) -> Array:
r"""Elementwise tangent: :math:`\mathrm{tan}(x)`."""
return tan_p.bind(x)

def asin(x: ArrayLike) -> Array:
r"""Elementwise arc sine: :math:`\mathrm{asin}(x)`."""
return asin_p.bind(x)
Expand Down Expand Up @@ -2014,7 +2014,11 @@ def _tan_impl(x):

tan_p = standard_unop(_float | _complex, 'tan')
ad.defjvp2(tan_p, lambda g, ans, x: mul(g, _const(x, 1) + square(ans)))
mlir.register_lowering(tan_p, partial(_nary_lower_hlo, chlo.tan))
def _lower_tan(ctx, x):
if ctx.is_forward_compat():
return _nary_lower_hlo(chlo.tan, ctx, x)
return _nary_lower_hlo(hlo.tan, ctx, x)
mlir.register_lowering(tan_p, _lower_tan)

def asin_impl(x):
if dtypes.issubdtype(_dtype(x), np.complexfloating):
Expand Down