-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update persistent compilation cache doc #22271
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I recommend asking Skye to do a pass as well.
Note: the cache does not have an eviction mechanism implemented. If the | ||
cache-location is a directory in the local filesystem, its size will continue | ||
to grow unless files are manually deleted. | ||
(3) Using [`set_cache_dir()`](https://github.com/google/jax/blob/jax-v0.4.26/jax/experimental/compilation_cache/compilation_cache.py#L18) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OOC why do we have a Python function for setting the cache dir? Wouldn't (1) and (2) be sufficient?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am also wondering
2ed1141
to
a23b505
Compare
I want to merge this first and request Syke to review a follow-up PR about LRU cache eviction. |
This is a follow-up of the PR #21819.