Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't compile persistent code on OSX #189

Closed
iZsh opened this issue Feb 5, 2018 · 3 comments
Closed

can't compile persistent code on OSX #189

iZsh opened this issue Feb 5, 2018 · 3 comments

Comments

@iZsh
Copy link

iZsh commented Feb 5, 2018

Hello,

we can't compile persistent code on OSX due to the --wrap option which is not supported:
This fails with both hfuzz-gcc and hfuzz-clang

ld: unknown option: --wrap=strcmp
collect2: error: ld returned 1 exit status
@robertswiecki
Copy link
Collaborator

We can probably #ifdef wrap's for MacOS as these are not critical.

But, the biggest problem is lack of persistent code in mac/arch.c - so it will not work. You can try compiling with

OS=POSIX make clean all

and give it a try under MacOS. Otherwise "somebody" (TM) would have to replicate the persistent logic inside mac/arch.c - the relevant code from posix/arch.c starts around here: https://github.com/google/honggfuzz/blob/master/posix/arch.c#L195

@robertswiecki
Copy link
Collaborator

I've surrounded --wrap by if-not-macosx define. These --wrap's are not critical. Thugh, still, persistent code is not in mac/arch.c - it's not very complex imo, just returning from a loop if a iteration sign has been received over socket, but given that I don't have access to MacOSX box now, I cannot implement it myself.

@robertswiecki
Copy link
Collaborator

I thimk this is fixed at HEAD. Please re-open if needed.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants